Smaller QR code - Githubissues

psanford / wormhole-william

End-to-end encrypted file transfer. A magic wormhole CLI and API in Go (golang).

MIT License

1.07k stars 54 forks source link

Closed ndrvtl closed 1 year ago

ndrvtl commented 2 years ago

Hi, in this patch I've enabled the qrterminals's "half-block" option to output a more compact QR code.

psanford commented 2 years ago

Thanks for this pr.

I have a few concerns about this as is. Based on https://github.com/mdp/qrterminal/issues/20 it appears that half block mode doesn't work on windows.

I also was unable to scan a qr code in xterm -fg black -bg white with the qr settings in this pr.

psanford commented 1 year ago

I'm going to close this out due to the unresolved issues. If someone wants to fix the issues listed above feel free to open a new pr.