search

psanford / wormhole-william

End-to-end encrypted file transfer. A magic wormhole CLI and API in Go (golang).
MIT License
1.07k stars 54 forks source link

Update Cobra to 1.5.0 to remove Viper dependency #81

Closed Jacalz closed 2 years ago

Jacalz commented 2 years ago

Cobra no longer depends on Viper as of https://github.com/spf13/cobra/releases/tag/v1.4.0. That means that the imports are far less and the cli binaries are ever so slightly smaller. There are also a bunch of other nice changes between 1.1.1 and 1.4.0. This PR updates the dependency so we can avoid pulling in unnecessary stuff as part of the go.sum file.

It also updates golang.org/x/crypto to silence security warning that doesn't impact us. Pkg.go.dev has started showing a link to https://deps.dev/go/github.com%2Fpsanford%2Fwormhole-william/v1.0.6, (https://deps.dev/go/github.com%2Fpsanford%2Fwormhole-william/v1.0.7-0.20220524221715-83b835953150 is the state on current master) which incorrectly shows a security warning that doesn't impact us. That doesn't look good, so let's just bump the package to avoid the warning.

I also bumped the minimum Go version in go.mod because Visual Studio Code was complaining that unsigned shifts require Go 1.13 or later. image

Jacalz commented 2 years ago

I'll get this updated to 1.5.0 now that it has been released.

Jacalz commented 2 years ago

Any chance that this could be reviewed? (I would have used the "Request review" feature if GitHub had let me use it)

cc @psanford