search

psanford / wormhole-william

End-to-end encrypted file transfer. A magic wormhole CLI and API in Go (golang).
MIT License
1.07k stars 54 forks source link

Upstreaming #88

Closed donpui closed 1 year ago

donpui commented 1 year ago

In Least Authority, we have recently two apps based on wormhole-william and magic-wormhole protocols: Destiny and Winden.app. We have made some changes in our fork of wormhole-william during development (C bindings, WASM bindings, Security audit findings implemented, Hashcash, Websocket implementation, and various smaller fixes/ refactoring). We would like to upstream them and make it easier for other builders to use these changes.

[Differences] (https://github.com/psanford/wormhole-william/compare/master...LeastAuthority:wormhole-william:master)

There are few questions pop out:

We have some further plans to continue development and add more features, for example, dilation and multiple files sending support. We would be happy to contribute these changes too and even help with maintaining the upstream repository to boost usage.

Jacalz commented 1 year ago

I think the smaller cleanups and bug fixes would be quite quick and easy to upstream. The larger binding changes will likely take a lot more time to review. My personal opinion would be that it is best if you can divide it up into a few different PRs to make it easy to review.