Overlap checker tool - Githubissues

Waqar-ukaea commented 2 weeks ago

Added overlap checker tool from DAGMC to check and identify overlapped regions in .h5m faceted files.

Checks for overlaps by looping through every triangle vertex in a mesh.
Added as a new tool
Cannot sample additional points along triangle edges (like DAGMC's version) as XDG::MeshManager does not have support to call MOAB functions that return entity adjacencies

Tested the tool on some h5m files locally and it seems like its working okay. It identifies when there are overlaps and which volumes are overlapped in agreement with DAGMC's version. Also added a new test file that runs the 5 test cases that DAGMC does for its overlap-checker tool.

One thing to note, the overlap location printed when running the tool doesn't necessarily match DAGMC's. I'm not sure what the cause of that is or if that is a major concern? Maybe due to differences in the order in which vertices are checked between the libraries?

Edit - CI fails because the .h5m files needed for those tests are missing from the repository. The files to be used with overlap-check's test's can be found here - test_files.zip. The CMakeLists.txt expects these files to be placed in ${XDG_ROOT}/tests/test_files

Waqar-ukaea commented 3 days ago

Fixed the inconsistent indentations you highlighted and a couple more I noticed, lmk if anything else needs editing.

I also removed the parsing of an argument to hold the number of points along a triangle edge to sample since I don't think we will be implementing that feature anymore and will instead go straight to ray_fire along edges check.

pshriwise commented 3 days ago

@Waqar-ukaea it looks like CI is still unhappy. Did the submodule get updated since that PR to the test files repo was merged?

pshriwise / xdg

Overlap checker tool #29