Final Project Feedback

[kuldeep23907]

Hi Peter – I am Kuldeep, a mentor who is assisting with the grading. Congratulations, your Final Project passed! We'll be approving it on the course itself in a week or two, but here's your feedback in the meanwhile:

Frontend Comments:

• UI looks cool. Good animation and clear user flow.
• Kovan testnet and mainnet. Why have you deployed on mainnet this soon?
• Github pages is used for deployment for MVP.

Testing comments:

• Structured properly using Describe. Unit testing is good. We can add a few integration testing test cases.
• Coverage of test cases scenarios looks good too.

Contract Comments:

• Smart Contract work is fine. There are multiple contracts from which you must have to learn something new. I liked that you modularised the codebase. Can we use a factory pattern to upgrade the contract level? Please think about it. Also, using a lot of storage is costly, maybe we can do some optimization using state packing.
• Access Control and Using Interfaces are the common design patterns and it's used in a good way here. Adding oracles is what's new here.
• Using specific compiler pragma and reentrancy check looks fine.
• Few library or interface has been used but encourage to use more from OZ.

Overall:

• Good to see a small use case of Oracles. Maybe this dapp can have its own ERC20 token and that could be listed & its price is shown on UI? Infinite possibilities. LP can be created for the dapp token & much more. The songs need to be saved on IPFS for proper decentralization if possible.
• Good to have either a MetaMask "Switch Network" button or an easier way for users to switch or at least not render content before. I had to refresh the page after changing networks, probably build it in an event listener or some other method to do that automatically. Also, account change can be handled in the same way.
• I would encourage you to see audio files stored on IPFS/Filecoin to make it more decentralized. Also if the artist can list their album with price directly without the help of an owner.
• Really cool idea and awesome implementation. Being a musician yourself, you have truly understood the importance of such a platform. Appreciate the effort. It's very well done. Suggest you go thru the project showcase of EthGlobal's hackathon where you can find similar projects which can help you in some way. Looking forward to seeing you in hackathons and doing more development in blockchain space & music.

Hope you enjoyed the learning journey so far and can continue building on this.

[psparacino]

Hi Kuldeep, thanks for the feedback! Yes I have plans to move the files to ipfs in a second iteration of this project as well as implement an ERC20 in some way.

Good to note on the network/account switching listener. As for the network, this should only be on kovan(?); there should be nothing on mainnet.

thanks again! appreciate the time and comments