search

pspdev / psplinkusb

General purpose homebrew/debugging toolkit for PSP
https://pspdev.github.io/debugging.html
BSD 3-Clause "New" or "Revised" License
64 stars 35 forks source link

Cleanup #10

Closed sharkwouter closed 4 years ago

sharkwouter commented 4 years ago

At the moment running make release builds psplink for the firmware versions 1.0 and 1.5 as well as for newer versions. This is no longer useful. I've removed them and instead build only the one for newer firmware versions. This cleans up this repo significantly.

I've tested the resulting eboot and it seems to work like before.

sharkwouter commented 4 years ago

I accidentally included my other PR in this branch as well. Should I change that?

carstene1ns commented 4 years ago

The intention of this commit is really nice. However packing all in one commit without proper message makes it difficult to review. I am going to recreate this locally to see if we can further remove things or if things are missing.

sharkwouter commented 4 years ago

Yeah, you're right. This is a big change and the changelog on github is a bit messy.

Here is a summary of the changes:

Should I redo this in individual commits or would this summary allow you to review it?

I've reverted the commit with the udev rule. That should not have landed in here, but I used checkout -b on the wrong branch when I creating this PR.

carstene1ns commented 4 years ago

Thank you for the explanation, makes it really easier to review! I would love to have this in at least 2 logical parts:

About the .gitignore change: I have added this to #12, so it can be removed.

After both these PRs merged, I think we are fine to release 3.0.1 finally.

sharkwouter commented 4 years ago

No problem, I'll spend some time on this on the weekend. Should I base this PR on #12?

carstene1ns commented 4 years ago

Is not needed, but you could review and merge it, if you want.