codepathreview
commented
10 years ago :+1: Great work overall Priyanka! Good job getting all the required stories done correctly along with a few extras. A few notes after checking out the code:
- Good polished UI to make the app twitter branded
- Good job formatting the relative time stamp (Consider externalizing the logic into Util class)
- Great job implementing PullToRefresh for refreshing tweets
- Consider using the ViewHolder pattern for your adapters. Assignments like these need it the most. If you see, sometimes the list loads stale data, ViewHolder should solve this problem.
- Nice touch adding the TextWatcher for counting characters
- Great job getting the links working in your tweets
- Consider using the ProgressBar indicating network requests
- Consider adding null checks in JSON parsing for robust error handling
Here's a detailed Project 3 Feedback Guide here which covers the most common issues with this submitted project. Read through the feedback guide point-by-point to determine how you could improve your submission.
Let us know if you have any other thoughts or questions about this assignment. Hopefully by now you feel pretty comfortable with all the major pieces to basic Android apps (Views, Controllers, ActionBar, Navigation, Models, Authentication, API Communication, Persistence, et al) and see how they all fit together. We are close now to a turning point in the course where you should be hitting a "critical mass" towards your knowledge of Android.
psshah
Hi, I've added the required user-stories and some optional features. README has more details. Can you please review the submission until now?. Thanks. /cc @nesquena @thecodepath