Refactor approval status comparators

psu-libraries / etda_workflow

Electronic Theses and Dissertations Application: Admin, Author, and Committee Member workflows.

MIT License

3 stars 1 forks source link

Open ajkiessl opened 3 months ago

ajkiessl commented 3 months ago

Anywhere we do a committee status or head of program status (from ApprovalStatus) comparison, we should be using the constants in ApprovalStatus:

APPROVED_STATUS = 'approved' REJECTED_STATUS = 'rejected' PENDING_STATUS = 'pending' NONE_STATUS = 'none'

It would be even better to refactor these comparisons into a single method like approved?, rejected?, etc.