search

ptitSeb / box64

Box64 - Linux Userspace x86_64 Emulator with a twist, targeted at ARM64 Linux devices
https://box86.org
MIT License
3.73k stars 267 forks source link

Support `sys_getpgrp` & `sys_getgpid` #1636

Closed Coekjan closed 2 months ago

Coekjan commented 2 months ago

These days I have some x64 applications relying on sys_getpgrp & sys_getgpid, but current x64Syscall() does not implement them.

I am not sure if they should be wrapped or emulated, but if I just wrapped them, my applications seemed working.

rajdakin commented 2 months ago

As a quick rule of thumb, if your program doesn't crash, you've probably implemented enough things correctly. Please do a PR (and if what you've done is not good enough, someone will tell you).

Also, this doesn't look like an issue, just a statement. What is/are the question(s)? (There is none in your comment above.)