search

ptitSeb / box64

Box64 - Linux Userspace x86_64 Emulator with a twist, targeted at ARM64 Linux devices
https://box86.org
MIT License
3.73k stars 267 forks source link

Fixes #1659

Closed rajdakin closed 2 months ago

rajdakin commented 2 months ago

This PR fixes most warnings that I could find (leaving out those which are either false positive or too bothersome to fix while being minor). The first commit also changes some tabs into spaces.

Coekjan commented 2 months ago

Also maybe we could add some more strict compiler flags to the CMakeLists.txt, at least optional? Would be great to catch these kinds of warnings/errors when writing the code.

Agree. Something like -Werror, -Wall. ~And for code-style, I think we could check the code style in CI (we have .clang-format already).~

ksco commented 2 months ago

About clang-format, please refer to #1387.