Board Members can show up under "positions" and "business positions" rather than "board members" list in some cases

[betsydupuis]

Ester Dyson's board positions show up this way, related to #1746.

I think it has something to do with the settings for organization type.

It might make sense to remove whatever logic that is making that distinction as the sorting logic is only adding confusion and is a tax on processing resources.

[josephlacey]

I've documented how the relationship groupings should work according to the code as I read it,

https://github.com/public-accountability/littlesis-rails/wiki/Relationship-type-definitions#profile-page

The Board Member and Board Memberships group is the most idiosyncratic one though. There's additional logic beyond just the checkbox that ends up causing it to get categorized in more general groups that seems to depend on which entity type is in the second position and if that entity type includes particular subtypes like "Business", which I suspect is the case with Ester's record

https://github.com/public-accountability/littlesis-rails/blob/main/app/models/link/subcategory.rb#L24

This probably needs either more clarification or the logic needs to be simplified.

[betsydupuis]

Hmm.... interesting problem.

This my intuitive take how I would reorganize it.

Organization Side

Board members can have a variety of relationships with the company, like being an outside investor or advisor, but they can also be the CEO for example or even just a staff member.

I suppose in theory, all of those positions should be separated out, but that makes for messy presentation without any roll-up logic for people with multiple roles at an organization.

Because board membership is a separate role, it makes the most sense to me to duplicate it across lists.

Board Members

• Board member is checked
• Does not remove from leadership
• Removes from staff, if employee not checked

Leadership

• Executive is checked
• Removes from staff but not from BOD
• Separated from staff

Staff

• Has a position with no boxes checked
• Board member is checked, but no other box, move to board members
• Employee + board member – keep in staff and board member
• Employee + executive – move to leadership and remove from staff

Person Side

Board Memberships

• All board memberships regardless of organization type, employment or executive status

Positions

• Duplicated for board memberships
• removed by other business and government positions
• businesses that are government owned such as the postal service. The logic currently works this way, although I lean towards have government trump business for these types of organizations. Intuitively, I think of the orgs in the wikipedia article as part of the government, but that's just my bias.

Business Positions

• Duplicated for board memberships
• belongs to a business organization

Government Positions

• Duplicated for board memberships
• belongs to a government organization