search

public-transport / friendly-public-transport-format

A format for APIs, libraries and datasets containing and working with public transport data.
Creative Commons Attribution Share Alike 4.0 International
125 stars 1 forks source link

add a location obj #25

Closed derhuerst closed 7 years ago

derhuerst commented 7 years ago

This PR adds the location object we discussed in #19. Closes #19. Also indirectly closes #15.

https://github.com/public-transport/friendly-public-transport-format/blob/124a937f4954dcc3c62201918a6b75e927f9c11f/spec/readme.md#L61-L63

How should I format this? This would also work:

location: { /* … */ } // location object, optional

https://github.com/public-transport/friendly-public-transport-format/blob/124a937f4954dcc3c62201918a6b75e927f9c11f/spec/readme.md#L198

This is still confusing. The proper, but too long and complex, description would be "station/stop object or id, or a location object". What do you think?

kiliankoe commented 7 years ago

Imo the current formatting of the inline location and // station/stop/location id or object, required are fine.

As for the actual content: LGTM 👍