search

public-transport / friendly-public-transport-format

A format for APIs, libraries and datasets containing and working with public transport data.
Creative Commons Attribution Share Alike 4.0 International
125 stars 1 forks source link

specify cancelled departures/arrivals #31

Closed derhuerst closed 6 years ago

derhuerst commented 6 years ago

closes #27

juliuste commented 6 years ago

canceled should be required, right? Everything else LGTM.

derhuerst commented 6 years ago

Should it? For now, I've only assigned it if the trips is actually canceled. Don't you think this is sufficient? Is making canceled required worth raising the barrier to use FPTF by a little?

juliuste commented 6 years ago

You're right, since this is about fptf@1 and it would be a breaking change, making it required here doesn't make sense. For fptf@2 we agreed that it should be required.

derhuerst commented 6 years ago

Note: This is actually a breaking change and should be PRed against next, also because it expects that departure/arrival may be null.