Change regular function to arrow function

liliyao2022 commented 2 years ago

💡Format this Issue Into a First Timers Issue

This has been marked as a good candidate for becoming a first-timers-only issue like these, meaning that it's simple, self-contained, and with some extra formatting✍️, could be a great entry point for a new contributor. If you're familiar enough with this code, please consider reformatting it as a first-timers-only issue, and then ping @publiclab/reviewers to get it labeled🏷. Or, if this is not your first time, try to solve it yourself🧑‍💻!

Hi, this is a first-timers-only issue. This means we've worked to make it more legible to folks who either haven't contributed to our codebase before, or even folks who haven't contributed to open source before.

If that's you, we're interested in helping you take the first step and can answer questions and help you out as you do. Note that we're especially interested in contributions from people from underrepresented groups in free and open-source software!

We know that the process of creating a pull request is one of the biggest barriers for new contributors. This issue is for you 💝

If you have contributed before, consider leaving this one for someone new, and looking through our general help wanted issues. Thanks!

🤔 What you will need to know.

Nothing. This issue is meant to welcome you to Open Source :) We are happy to walk you through the process.

📋 Step by Step

[ ] 🙋 Claim this issue: Claim the issue by commenting. If someone else has claimed it, ask if they've opened a pull request already and if they're stuck -- maybe you can help them solve a problem or move it along!

💡 Learn how to claim 🙋

Claiming an issue

Unless the issue is marked as reserved for someone, you can just say "I'd like to try this!" and then you've claimed it - no need to wait for someone to assign it to you. Just be sure you link your pull request (PR) to this issue so we can see where your solution is.

And open one early if possible - even before you've completed it with additional commits - and others can help you figure out any issues you may face.

[ ] 📝 Update the file https://github.com/publiclab/Leaflet.DistortableImage/blob/main/Gruntfile.js in the $REPO repository (press the little pen Icon) and edit the line as shown below.

See this page for some help in taking your first steps!

Below is a "diff" showing in red (and a -) which lines to remove, and in green (and a +) which lines to add:

3 - module.exports = function(grunt) { $DIFF 3 +module.exports = (grunt)=> {

5 - require('matchdep').filterDev('{grunt,gruntify}-').filter(function(pkg) { $DIFF 5+ require('matchdep').filterDev('{grunt,gruntify}-').filter((pkg) => {

101 - grunt.registerTask('coverage', 'CLI reporter for karma-coverage', function() { $DIFF 101 + grunt.registerTask('coverage', 'CLI reporter for karma-coverage', ()=> {

[ ] 💾 Commit your changes
[ ] 🔀 Start a Pull Request. There are two ways how you can start a pull request:

If you are familiar with the terminal or would like to learn it, here is a great tutorial on how to send a pull request using the terminal.
You can also edit files directly in your browser and open a pull request from there.

[ ] 🏁 Done Ask in comments for a review :)

🤔❓ Questions?

Is someone else already working on this?

We encourage you to link to this issue by mentioning the issue # in your pull request, so we can see if someone's already started on it. If someone seems stuck, offer them some help! Otherwise, take a look at some other issues you can help with. Thanks!

(This issue was created by First-Timers-Bot.)

liliyao2022 commented 2 years ago

There is still something wrong, can anyone help me with it? The "DIFF" part is quite confusing. I've tried so many times, however, it doesn't show as I think it would.

Achele commented 2 years ago

Hello @liliyao2022, to get the "DIFF" showing properly follow this steps: step 1: delete the $DIFF in between the diff backticks

$DIFF

Step 2: Add your lines of code in between the backticks "diff {lines of code here} ``

-3  module.exports = function(grunt) {
+3   module.exports = (grunt) => {

-5  require('matchdep').filterDev('{grunt,gruntify}-').filter(function(pkg) {
+5  require('matchdep').filterDev('{grunt,gruntify}-').filter((pkg) => {

-101  grunt.registerTask('coverage', 'CLI reporter for karma-coverage', function() {
+101 grunt.registerTask('coverage', 'CLI reporter for karma-coverage', ()=> {

I hope this was helpful

Ashism766 commented 2 years ago

I want to work on this.

Ashism766 commented 2 years ago

@liliyao2022 @Achele please can you review my PR

TildaDares commented 2 years ago

Hi @Ashism766, you need to push upstream and not to your own fork. Thanks!

Ashism766 commented 2 years ago

"remote: Permission to publiclab/Leaflet.DistortableImage.git denied to Ashism766. fatal: unable to access ' https://github.com/publiclab/Leaflet.DistortableImage.git/': The requested URL returned error: 403" This is showing please help?

On Wed, 2 Nov 2022 at 11:43, Tilda Udufo @.***> wrote:

Hi @Ashism766 https://github.com/Ashism766, you need to push upstream and not to your own fork. Thanks!

— Reply to this email directly, view it on GitHub https://github.com/publiclab/Leaflet.DistortableImage/issues/1244#issuecomment-1299629128, or unsubscribe https://github.com/notifications/unsubscribe-auth/ATRI3BXYNX6KNAMLFIEX65LWGIBBTANCNFSM6AAAAAARPTTC7A . You are receiving this because you were mentioned.Message ID: @.***>

TildaDares commented 2 years ago

Hi @Ashism766, you can follow the guide here https://www.digitalocean.com/community/tutorials/how-to-create-a-pull-request-on-github. You can skip tests you've already done. Thank you!

Ashism766 commented 2 years ago

@TildaDares please review my PR.

publiclab / Leaflet.DistortableImage