Update export.html - Githubissues

olamideazeez commented 2 years ago

Adding the closing body tag in the export.html file

Fixes #1218 (<=== Add issue number here)

Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!

[x] PR is descriptively titled 📑 and links the original issue above 🔗
[x] tests pass -- look for a green checkbox ✔️ a few minutes after opening your PR -- or run tests locally with grunt test
[x] code is in uniquely-named feature branch and has no merge conflicts 📁
[x] screenshots/GIFs are attached 📎 in case of UI updates
[x] @mention the original creator of the issue in a comment below for help or for a review

We're happy to help you get this ready -- don't be afraid to ask for help, and don't be discouraged if your tests fail at first!

If tests do fail, click on the red X to learn why by reading the logs.

Please be sure you've reviewed our contribution guidelines at https://publiclab.org/contributing-to-public-lab-software

Thanks!

gitpod-io[bot] commented 2 years ago

olamideazeez commented 2 years ago

hello @TildaDares i have created a pull request

olamideazeez commented 2 years ago

@segun-codes please kindly review

segun-codes commented 2 years ago

@segun-codes please kindly review

Hi @olamideazeez, sorry, reviews are done by our mentors. I am just an intern hopeful like you.

7malikk commented 2 years ago

@olamideazeez It looks good, should be merged at the nearest convenience @segun-codes even as an intern, you can still review the works of others. @TildaDares @cesswairimu would appreciate it

segun-codes commented 2 years ago

@olamideazeez It looks good, should be merged at the nearest convenience @segun-codes even as an intern, you can still review the works of others. @TildaDares @cesswairimu would appreciate it

Oh! nice... I thought reviewing his work could amount to crossing my bounds in this case as intern. Thanks @7malikk.

TildaDares commented 2 years ago

Hi @olamideazeez, can you merge the changes in this PR and #1247 into a single PR as they both resolve the same issue. Thanks!

olamideazeez commented 2 years ago

Hi @olamideazeez, can you merge the changes in this PR and #1247 into a single PR as they both resolve the same issue. Thanks!

hi @TildaDares please can i get a tip on how i can do that?

publiclab / Leaflet.DistortableImage

Update export.html #1248