search

publiclab / Leaflet.DistortableImage

A Leaflet extension to distort or "rubber sheet" images
https://publiclab.github.io/Leaflet.DistortableImage/examples/
BSD 2-Clause "Simplified" License
265 stars 284 forks source link

Changed let to const in src/edit/DistortableImage.Edit.js #1318

Closed AtulyaJaiswal closed 1 year ago

AtulyaJaiswal commented 1 year ago

Fixes #1318

I have updated the document from let to const in src/edit/DistortableImage.Edit.js . I am sorry for the last comment, please don't mind as I am very new to open source and I was not aware how to write comment, very sorry for this.

welcome[bot] commented 1 year ago

Thanks for opening this pull request! Dangerbot will test out your code and reply in a bit with some pointers and requests. There may be some errors, but don't worry! We're here to help! 👍🎉😄
One thing that can help to get started is to make sure you've included a link back to the original issue you're solving, in the format fixes #0000 (for example). And to make sure the PR title describes what you're trying to do! (often it can be the same as the issue title) Thanks! 🙌
Then, you can say hello in our chatroom & share a link to this PR to get a review! 👋 ✅

cesswairimu commented 1 year ago

Hi @AtulyaJaiswal , thanks for opening this, could you please add a link to the issue this pull request fixes on the description --- On this this lineFixes #0000 (replace 0000 with the issue number) this will help other contributors while reviewing your changes. It also helps in automatically closing the issue when the pull request is merged. Thanks

AtulyaJaiswal commented 1 year ago

@cesswairimu sir, I have updated the comment. Sorry for the inconvenience.

cesswairimu commented 1 year ago

no worries @AtulyaJaiswal, I meant the issue you are fixing with this PR, i believe it's this one https://github.com/publiclab/Leaflet.DistortableImage/issues/1309 right? and no biggie but my pronouns are she/her. Thanks

AtulyaJaiswal commented 1 year ago

Thank you @cesswairimu for your valuable feedback.

segun-codes commented 1 year ago

Thank you @cesswairimu for your valuable feedback.

@TildaDares, I guess you want to consider merging this now. Many thanks!

TildaDares commented 1 year ago

Thank you for the reviews @segun-codes @cesswairimu.

Great work @AtulyaJaiswal 🚀

welcome[bot] commented 1 year ago

Congrats on merging your first pull request! 🙌🎉⚡️ Your code will likely be published to https://mapknitter.org in the next few days. Now that you've completed this, you can help someone else take their first step! Reach out to someone else working on theirs on Public Lab's code welcome page (where you'll now be featured as a recent contributor!). Thanks!

Help others take their first step

Now that you've merged your first pull request, you're the perfect person to help someone else out with this challenging first step. 🙌

https://code.publiclab.org

Try looking at this list of `first-timers-only` issues, and see if someone else is waiting for feedback, or even stuck! 😕

People often get stuck at the same steps, so you might be able to help someone get unstuck, or help lead them to some documentation that'd help. Reach out and be encouraging and friendly! 😄 🎉

Read about how to help support another newcomer here, or find other ways to offer mutual support here.

7malikk commented 1 year ago

Congratulations on your merge @AtulyaJaiswal 🎉 Good job!

AtulyaJaiswal commented 1 year ago

Thank you @segun-codes @TildaDares @cesswairimu @7malikk.