publiclab / mapknitter

Upload your own aerial images, position (rubbersheet) them in a web interface over existing map data, and share via web or composite and export for print.
http://mapknitter.org
GNU General Public License v3.0
267 stars 207 forks source link

Fix to dropdown menu #1689

Closed FoleyDom closed 2 years ago

FoleyDom commented 2 years ago

Fixes #1683 (<=== Add issue number here)

Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!

We're happy to help you get this ready -- don't be afraid to ask for help, and don't be discouraged if your tests fail at first!

If tests do fail, click on the red X to learn why by reading the logs.

Please be sure you've reviewed our contribution guidelines at https://publiclab.org/contributing-to-public-lab-software

Thanks!

Please let me how I did and if I need to change anything. Thanks

welcome[bot] commented 2 years ago

Thanks for opening this pull request! Dangerbot will test out your code and reply in a bit with some pointers and requests. There may be some errors, but don't worry! We're here to help! 👍🎉😄

gitpod-io[bot] commented 2 years ago

codeclimate[bot] commented 2 years ago

Code Climate has analyzed commit 26207ac2 and detected 0 issues on this pull request.

View more on Code Climate.

FoleyDom commented 2 years ago

I attempted to do the changes on my own system after downloading everything but I'm not sure if I downloaded everything right. But learned a lot from trying.

codecov[bot] commented 2 years ago

Codecov Report

Merging #1689 (e340552) into main (d501aa4) will decrease coverage by 0.21%. The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1689      +/-   ##
==========================================
- Coverage   71.89%   71.68%   -0.22%     
==========================================
  Files          40       40              
  Lines        1409     1409              
==========================================
- Hits         1013     1010       -3     
- Misses        396      399       +3     
Impacted Files Coverage Δ
lib/exporter.rb 91.92% <0.00%> (-2.25%) :arrow_down:
app/models/map.rb 93.54% <0.00%> (+1.29%) :arrow_up:
FoleyDom commented 2 years ago

Please let me know if everything is done correctly. Sorry about my mistake before.

welcome[bot] commented 2 years ago

Congrats on merging your first pull request! 🙌🎉⚡️ Your code will likely be published to https://mapknitter.org in the next few days. In the meantime, can you tell us your Twitter handle so we can thank you properly? Now that you've completed this, you can help someone else take their first step! Reach out to someone else working on theirs on Public Lab's code welcome page. Thanks!

Help others take their first step

Now that you've merged your first pull request, you're the perfect person to help someone else out with this challenging first step. 🙌

https://code.publiclab.org

Try looking at this list of `first-timers-only` issues, and see if someone else is waiting for feedback, or even stuck! 😕

People often get stuck at the same steps, so you might be able to help someone get unstuck, or help lead them to some documentation that'd help. Reach out and be encouraging and friendly! 😄 🎉

Read about how to help support another newcomer here, or find other ways to offer mutual support here.