dependabot[bot] commented 2 years ago

Bumps leaflet from 1.5.1 to 1.8.0.

Release notes

v1.8.0 is a culmination of 1.5 years of development, a huge release focused on bug fixes, major reliability and accessibility improvements, cleaning up legacy code, and numerous improvements to documentation, development workflow and release process. A culmination of hundreds of contributions, and a preparation for bigger changes to come. 🍃

I'm making this release just as an air raid alert is sounding outside, in Kyiv, warning about an imminent Russian air strike. This release is dedicated to Ukrainian fight for freedom and democracy against the Russian invasion 🇺🇦 (see how you can support Ukraine here).

From now on, releases will become much more frequent. Thanks to our amazing community for all your help and patience. ❤️🙏 Special thanks to @johnd0e who revived Leaflet development after long stagnation and made the biggest contributions, @Falke-Design for doing the bulk of the work organizing development and preparing the release, @Malvoz for his numerous accessibility contributions, and @jonkoops for help with workflow automations. ❤️

⚠️ Breaking Changes

Improve reliability of contextmenu event simulation on mobile Safari by introducing a new TapHold handler, replacing legacy Tap (#7026 by @johnd0e)

Reorganize DivOverlay/Popup/Tooltip APIs (#7540 by @johnd0e)

Move Popup related options from DivOverlay to Popup (#7778 by @Falke-Design)

Change Tooltip class from leaflet-clickable to leaflet-interactive (#7719 by @Falke-Design)

Map.closeTooltip now requires a layer as argument (#7533 by @johnd0e)

Improve error / argument handling for event listeners (#7518 by @johnd0e)

Improve reliability of touch events simulation on non-touch devices (DomEvent.Pointer) (#7059, #7084, #7415 by @johnd0e)

Improve reliability of dblclick event simulation on touch devices (DomEvent.DoubleTap) (#7027 by @johnd0e)

Improve reliability of disableClickPropagation (#7439 by @johnd0e)

Improve Map hasLayer() and LayerGroup hasLayer() to require a layer as argument (#6999 by @johnd0e)

Fix Class.include to not overwrite options (#7756 by @johnd0e)

Fix Class.extend to not modify source props object (#6766 by @johnd0e)

Improve Browser.touch touch devices detection (#7029 by @johnd0e)

Get rid of legacy Android hacks (#7022 by @johnd0e)

Allow fonts to respect users' browser settings by making the font-size relative to the map container. (You can change the font size on leaflet-container to adjust it if needed.) (#7800 by @Chandu-4444)

❇️ API changes

Make DivOverlay / Tooltip interactive (#7531, #7532 by @johnd0e)

Add openOn, close, toggle functions to DivOverlay (#6639 by @johnd0e)

Introduce DomEvent.off(el) to remove all listeners (#7125 by @johnd0e)

Allow preventing round-off errors by passing false to Util.formatNum / toGeoJSON (#7100 by @johnd0e)

Add autoPanOnFocus to Marker (#8042 by @IvanSanchez)

Add referrerPolicy to TileLayer (#7945 by @natevw)

Add playsInline to VideoOverlay (#7928 by @Falke-Design)

Add getCenter to ImageOverlay (#7848 by @Falke-Design)

Fire a tileabort event when a TileLayer load is cancelled (#6786 by @dstndstn)

Add crossOrigin to Icon (#7298 by @syedmuhammadabid)

✨ Improvements

Improve memory footprint by removing will-change CSS property on tile images (#7872 by @janjaap)

Improve reliability of icons path detection heuristics (#7092 by @johnd0e)

Improve performance of adding tiled sources by avoiding excessive updates in GridLayer.onAdd (#7570 by @johnd0e)

Improve handling of edge cases in panInside (#7469 by @daverayment)

Minify marker icon SVG (#7600 by @rala72)

Allow template keys with spaces in TileLayer URL (#7216 by @lubojr)

Improve behavior of Tooltip bound to ImageOverlay (#7306 by @IvanSanchez)

Remove the gap between Popup tip and content dialog (#7920 by @Malvoz)

Fire mousemove through Canvas to map if it has no layers (#7809 by @johnd0e)

Add print styles to prevent printers from removing background-images in controls (#7851 by @Malvoz)

Move attribution code from Layer to Control.Attribution (#7764 by @johnd0e)

... (truncated)

Commits

8a1ccbe 1.8.0
fcd7af2 update changelog for v1.8.0
0c86a35 Small enhancement to the popup's close button (#7908)
0daaa23 Link to marker accessibility guideline from docs (#8146)
a4db892 Fix missing plugins section: Synthetic Overlays (#8148)
c7aadab DomUtil function tests (#7547)
b3e1b24 Allow raw latlng array in latLngToCoords/latLngsToCoords (#7436)
25546fc Popup should have a min-height (#8136)
d9ef8c1 Bump actions/cache from 3.0.1 to 3.0.2 (#8135)
85ca2c5 Bump eslint from 8.12.0 to 8.13.0 (#8132)
Additional commits viewable in compare view

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.

Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

gitpod-io[bot] commented 2 years ago

codeclimate[bot] commented 2 years ago

Code Climate has analyzed commit 4f3362d0 and detected 0 issues on this pull request.

View more on Code Climate.

codecov[bot] commented 2 years ago

Codecov Report

Merging #1701 (d403e73) into main (ce39aad) will not change coverage. The diff coverage is n/a.

:exclamation: Current head d403e73 differs from pull request most recent head 3cc7d0c. Consider uploading reports for the commit 3cc7d0c to get more accurate results

@@           Coverage Diff           @@
##             main    #1701   +/-   ##
=======================================
  Coverage   63.47%   63.47%           
=======================================
  Files          39       39           
  Lines        1180     1180           
=======================================
  Hits          749      749           
  Misses        431      431

jywarren commented 2 years ago

Getting this error:

Minitest::UnexpectedError:         RuntimeError: Wrapped undumpable exception for: ActionView::Template::Error: couldn't find file 'leaflet/dist/leaflet-src.js' with type 'application/javascript'
        Checked in these paths: 
          /home/runner/work/mapknitter/mapknitter/app/assets/images
          /home/runner/work/mapknitter/mapknitter/app/assets/javascripts
          /home/runner/work/mapknitter/mapknitter/app/assets/stylesheets
          /home/runner/work/mapknitter/mapknitter/vendor/assets/images
          /home/runner/work/mapknitter/mapknitter/vendor/assets/javascripts
          /home/runner/work/mapknitter/mapknitter/vendor/assets/stylesheets
          /home/runner/work/mapknitter/mapknitter/vendor/bundle/ruby/2.7.0/gems/actioncable-5.2.8/lib/assets/compiled
          /home/runner/work/mapknitter/mapknitter/vendor/bundle/ruby/2.7.0/gems/activestorage-5.2.8/app/assets/javascripts
          /home/runner/work/mapknitter/mapknitter/vendor/bundle/ruby/2.7.0/gems/actionview-5.2.8/lib/assets/compiled
          /home/runner/work/mapknitter/mapknitter/public/lib
          /home/runner/work/mapknitter/mapknitter/public/lib
          /home/runner/work/mapknitter/mapknitter/node_modules
          /home/runner/work/mapknitter/mapknitter/vendor/bundle/ruby/2.7.0/gems/popper_js-2.9.3/assets/javascripts
            app/assets/javascripts/application.js:15
            app/views/front_ui/index.html.erb:97:in `_app_views_front_ui_index_html_erb___1[33](https://github.com/publiclab/mapknitter/runs/6672420380?check_suite_focus=true#step:7:34)6796720856858010_86520'
            test/integration/front_page_test.rb:6:in `block in <class:FrontPageTest>'

====================================================================|

jywarren commented 2 years ago

Confirmed here we can use Leaflet 1.8! https://github.com/publiclab/Leaflet.DistortableImage/pull/965

jywarren commented 2 years ago

Manually confirmed this works upstream in Leaflet.DistortableImage!

publiclab / mapknitter

Bump leaflet from 1.5.1 to 1.8.0 #1701

⚠️ Breaking Changes

❇️ API changes

✨ Improvements

Codecov Report