search

publiclab / mapknitter

Upload your own aerial images, position (rubbersheet) them in a web interface over existing map data, and share via web or composite and export for print.
http://mapknitter.org
GNU General Public License v3.0
267 stars 207 forks source link

Bump rubocop from 1.12.1 to 1.30.0 #1731

Closed dependabot[bot] closed 2 years ago

dependabot[bot] commented 2 years ago

Bumps rubocop from 1.12.1 to 1.30.0.

Release notes

Sourced from rubocop's releases.

RuboCop 1.30

New features

  • #10065: Add new Gemspec/DeprecatedAttributeAssignment cop. (@​koic)
  • #10608: Add new Style/MapCompactWithConditionalBlock cop. (@​nobuyo)
  • #10627: Add command-line option --ignore-unrecognized-cops to ignore any unknown cops or departments in .rubocop.yml. (@​nobuyo)
  • #10620: Add Sorbet's typed sigil as a magic comment. (@​zachahn)

Bug fixes

  • #10662: Recover Ruby 2.1 code analysis using TargetRubyVersion: 2.1. (@​koic)
  • #10396: Fix autocorrect for Layout/IndentationWidth to leave module/class body unchanged to avoid infinite autocorrect loop with Layout/IndentationConsistency when body trails after class/module definition. (@​johnny-miyake)
  • #10636: Fix false positive in Style/RedundantCondition when the branches call the same method on different receivers. (@​dvandersluis)
  • #10651: Fix autocorrect for Style/For when using array with operator methods as collection. (@​nobuyo)
  • #10629: Fix default Ruby version from 2.5 to 2.6. (@​koic)
  • #10661: Fix a false negative for Style/SymbolProc when method has no arguments and AllowMethodsWithArguments: true. (@​koic)
  • #10631: Fix autocorrect for Style/RedundantBegin. (@​johnny-miyake)
  • #10652: Fix a false positive for Style/FetchEnvVar in conditions. (@​ydah)
  • #10665: Fix an incorrect autocorrect for EnforcedStyle: with_first_argument of Layout/ArgumentAlignment and EnforcedColonStyle: separator of Layout/HashAlignment. (@​koic)
  • #10258: Recover Ruby 2.4 code analysis using TargetRubyVersion: 2.4. (@​koic)
  • #10668: Recover Ruby 2.0 code analysis using TargetRubyVersion: 2.0. (@​koic)
  • #10644: Recover Ruby 2.2 code analysis using TargetRubyVersion: 2.2. (@​koic)
  • #10639: Fix Style/HashSyntax to exclude files that violate it with EnforceHashShorthandSyntax when running auto-gen-config. (@​nobuyo)
  • #10633: Fix infinite autocorrection loop in Style/AccessorGrouping when combining multiple of the same accessor. (@​dvandersluis)
  • #10618: Fix LineBreakCorrector so that it won't remove a semicolon in the class/module body. (@​johnny-miyake)
  • #10646: Fix an incorrect autocorrect for Style/SoleNestedConditional when using unless and && without parens in the outer condition and nested modifier condition. (@​koic)
  • #10659: Fix automatically appended path for inherit_from by auto-gen-config is incorrect if specified config file in a subdirectory as an option. (@​nobuyo)
  • #10640: Recover Ruby 2.3 code analysis using TargetRubyVersion: 2.3. (@​koic)
  • #10657: Fix --auto-gen-config command option ignores specified config file by option. (@​nobuyo)

Changes

  • #10095: Change "auto-correct" to "autocorrect" in arguments, documentation, messages, comments, and specs. (@​chris-hewitt)
  • #10656: Mark Style/RedundantInterpolation as unsafe autocorrection. (@​koic)
  • #10616: Markdown formatter: skip files with no offenses. (@​rickselby)

RuboCop 1.29.1

Bug fixes

  • #10625: Restore the specification to TargetRubyVersion: 2.5. (@​koic)
  • #10569: Fix a false positive for Style/FetchEnvVar when using the same ENV var as if condition in the body. (@​koic)

... (truncated)

Changelog

Sourced from rubocop's changelog.

1.30.0 (2022-05-26)

New features

  • #10065: Add new Gemspec/DeprecatedAttributeAssignment cop. ([@​koic][])
  • #10608: Add new Style/MapCompactWithConditionalBlock cop. ([@​nobuyo][])
  • #10627: Add command-line option --ignore-unrecognized-cops to ignore any unknown cops or departments in .rubocop.yml. ([@​nobuyo][])
  • #10620: Add Sorbet's typed sigil as a magic comment. ([@​zachahn][])

Bug fixes

  • #10662: Recover Ruby 2.1 code analysis using TargetRubyVersion: 2.1. ([@​koic][])
  • #10396: Fix autocorrect for Layout/IndentationWidth to leave module/class body unchanged to avoid infinite autocorrect loop with Layout/IndentationConsistency when body trails after class/module definition. ([@​johnny-miyake][])
  • #10636: Fix false positive in Style/RedundantCondition when the branches call the same method on different receivers. ([@​dvandersluis][])
  • #10651: Fix autocorrect for Style/For when using array with operator methods as collection. ([@​nobuyo][])
  • #10629: Fix default Ruby version from 2.5 to 2.6. ([@​koic][])
  • #10661: Fix a false negative for Style/SymbolProc when method has no arguments and AllowMethodsWithArguments: true. ([@​koic][])
  • #10631: Fix autocorrect for Style/RedundantBegin. ([@​johnny-miyake][])
  • #10652: Fix a false positive for Style/FetchEnvVar in conditions. ([@​ydah][])
  • #10665: Fix an incorrect autocorrect for EnforcedStyle: with_first_argument of Layout/ArgumentAlignment and EnforcedColonStyle: separator of Layout/HashAlignment. ([@​koic][])
  • #10258: Recover Ruby 2.4 code analysis using TargetRubyVersion: 2.4. ([@​koic][])
  • #10668: Recover Ruby 2.0 code analysis using TargetRubyVersion: 2.0. ([@​koic][])
  • #10644: Recover Ruby 2.2 code analysis using TargetRubyVersion: 2.2. ([@​koic][])
  • #10639: Fix Style/HashSyntax to exclude files that violate it with EnforceHashShorthandSyntax when running auto-gen-config. ([@​nobuyo][])
  • #10633: Fix infinite autocorrection loop in Style/AccessorGrouping when combining multiple of the same accessor. ([@​dvandersluis][])
  • #10618: Fix LineBreakCorrector so that it won't remove a semicolon in the class/module body. ([@​johnny-miyake][])
  • #10646: Fix an incorrect autocorrect for Style/SoleNestedConditional when using unless and && without parens in the outer condition and nested modifier condition. ([@​koic][])
  • #10659: Fix automatically appended path for inherit_from by auto-gen-config is incorrect if specified config file in a subdirectory as an option. ([@​nobuyo][])
  • #10640: Recover Ruby 2.3 code analysis using TargetRubyVersion: 2.3. ([@​koic][])
  • #10657: Fix --auto-gen-config command option ignores specified config file by option. ([@​nobuyo][])

Changes

  • #10095: Change "auto-correct" to "autocorrect" in arguments, documentation, messages, comments, and specs. ([@​chris-hewitt][])
  • #10656: Mark Style/RedundantInterpolation as unsafe autocorrection. ([@​koic][])
  • #10616: Markdown formatter: skip files with no offenses. ([@​rickselby][])

1.29.1 (2022-05-12)

Bug fixes

  • #10625: Restore the specification to TargetRubyVersion: 2.5. ([@​koic][])
  • #10569: Fix a false positive for Style/FetchEnvVar when using the same ENV var as if condition in the body. ([@​koic][])
  • #10614: Make Lint/NonDeterministicRequireOrder aware of require_relative. ([@​koic][])
  • #10607: Fix autocorrect for Style/RedundantCondition when there are parenthesized method calls in each branch. ([@​nobuyo][])
  • #10622: Fix a false positive for Style/RaiseArgs when error type class constructor with keyword arguments and message argument. ([@​koic][])
  • #10610: Fix an error for Naming/InclusiveLanguage string with invalid byte sequence in UTF-8. ([@​ydah][])
  • #10605: Fix autocorrect for Style/RedundantCondition if argument for method in else branch is hash without braces. ([@​nobuyo][])

1.29.0 (2022-05-06)

... (truncated)

Commits
  • 3fd4828 Cut 1.30
  • f14c944 Update Changelog
  • 5eef8fa [Fix #10652] Fix a false positive for Style/FetchEnvVar in conditions
  • faa98e3 [Fix #10665] Fix an incorrect autocorrect for Layout/ArgumentAlignment
  • 91b7573 [Fix #10659] Fix automatically appended path for inherit_from by `auto-gen-...
  • 825b758 Add a reproduction test to autocorrect_spec.rb
  • 8396e08 [Fix #10396] Fix autocorrect for Layout/IndentationWidth to leave module/cl...
  • 0e8d924 Add new Style/MapCompactWithConditionalBlock cop
  • a4c197c Recover Ruby 2.0 code analysis using TargetRubyVersion: 2.0
  • bfe86b1 Merge pull request #10667 from ydah/fix_typo
  • Additional commits viewable in compare view


Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.

Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
gitpod-io[bot] commented 2 years ago

codeclimate[bot] commented 2 years ago

Code Climate has analyzed commit 73fc2034 and detected 0 issues on this pull request.

View more on Code Climate.

codecov[bot] commented 2 years ago

Codecov Report

Merging #1731 (25edd05) into main (b66b754) will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1731   +/-   ##
=======================================
  Coverage   63.47%   63.47%           
=======================================
  Files          39       39           
  Lines        1180     1180           
=======================================
  Hits          749      749           
  Misses        431      431
jywarren commented 2 years ago

The error log clearly points out some possible causes!

.rubocop.yml:1: `require` is concealed by line 2
.rubocop.yml: Metrics/LineLength has the wrong namespace - should be Layout
Warning: obsolete parameter `IgnoredPatterns` (for `Layout/LineLength`) found in vendor/bundle/ruby/2.[7](https://github.com/publiclab/mapknitter/runs/6644924171?check_suite_focus=true#step:4:8).0/gems/rubocop-shopify-2.0.1/rubocop.yml
`IgnoredPatterns` has been renamed to `AllowedPatterns`.
Error: unrecognized cop or department Lint/UselessElseWithoutRescue found in vendor/bundle/ruby/2.7.0/gems/rubocop-shopify-2.0.1/rubocop.yml
Did you mean `Lint/UselessSetterCall`?
Error: Process completed with exit code 2.
dependabot[bot] commented 2 years ago

Superseded by #1749.