search

publiclab / mapknitter

Upload your own aerial images, position (rubbersheet) them in a web interface over existing map data, and share via web or composite and export for print.
http://mapknitter.org
GNU General Public License v3.0
267 stars 210 forks source link

CodeCov not registering recent test reports #1733

Closed jywarren closed 2 years ago

jywarren commented 2 years ago

I'm trying to get it to accept them by introducing the workflow-based trigger from plots2 -- here's the new trigger:

https://github.com/publiclab/mapknitter/commit/423d7cbfacda3e2f318761710144724166dcef00#diff-1db27d93186e46d3b441ece35801b244db8ee144ff1405ca27a163bfe878957fR5-R7

https://github.com/publiclab/mapknitter/actions/runs/2393173328 was successfully retriggered on the final commit as a result.

It otherwise hasnt run since ~May 13th, https://github.com/publiclab/mapknitter/commit/d501aa44f8bdb7e7b6c33073a6939e36a3214929

(see https://github.com/publiclab/mapknitter/pull/1730#issuecomment-1139060832 for example)

jywarren commented 2 years ago

Don't think this is related but i did just update simplecov: https://github.com/publiclab/mapknitter/pull/1729

jywarren commented 2 years ago

I think the change in https://github.com/publiclab/mapknitter/commit/423d7cbfacda3e2f318761710144724166dcef00#diff-1db27d93186e46d3b441ece35801b244db8ee144ff1405ca27a163bfe878957fR5-R7 worked... at least, PRs seem to be passing now and registering a new commit!

jywarren commented 2 years ago

this didn't pass but i didn't rebase it so maybe that was the issue: https://github.com/publiclab/mapknitter/pull/1728