publiclab / mapknitter

Upload your own aerial images, position (rubbersheet) them in a web interface over existing map data, and share via web or composite and export for print.
http://mapknitter.org
GNU General Public License v3.0
267 stars 208 forks source link

MapKnitter Upgrades planning (overall) #300

Open jywarren opened 5 years ago

jywarren commented 5 years ago

MapKnitter upgrades being considered and planned fall into a few different categories:

  1. MapKnitter Exporter (#298 and #296)
  2. Rails upgrades + testing
  3. MapKnitter UI

We'll break these out in more detail in separate issues, but do a brief overview here. For all planning issues, see:

https://github.com/publiclab/mapknitter/projects/1

Some of the changes will be aimed at infrastructure and sustainability, as we can't make big changes or improvements without, for example, better tests and a more up-to-date Rails stack. Others will be bug fixes and cleanup of the existing system. Finally, some changes will include a massive optimization of the export system backed by Google Cloud (or equivalent serverless backend), and some more serious UI changes to the map creation, login, and image upload workflows, as well as the map display pages.

A rough working diagram of MapKnitter 2.5 can be found here: https://docs.google.com/presentation/d/12NU6V9UFeOWKJrql8AIQZI3mKUWTuakF8zrGpOlgrNg/edit#slide=id.g49650b018b_0_0

Here are the overall projects; be aware that we may not prioritize each of these, and may try to focus on some of the most urgent and impactful for starters:

Stand-alone Cloud Exporter project

See #298 for in-depth discussion!

Rails upgrades

New Rails dev

Image position versioning, latency, etc

Leaflet.DistortableImage upgrades

Moving most to here: https://github.com/publiclab/Leaflet.DistortableImage/issues/126

User Interface (brainstorm here, needs organizing)

Leaflet Environmental Layers

Big ideas

These ideas will likely be too large for this project but let's think about them and plan for the future.

jywarren commented 5 years ago

This is pretty big, folks! Just a heads up to @icarito @tech4GT @SidharthBansal @gauravano that this is coming up pretty soon. Interested to hear your input!

SidharthBansal commented 5 years ago

I think we should write project titles in this issue and open up issues for each of the above to discuss. If we will discuss projects in this issue then things will become confusing, overlapping, conflicting and will result in diverge discussions. Let's break the above into individual issues and discuss each project mentioned by Jeff above in its separate issue. Few points which I observe:

SidharthBansal commented 5 years ago

Other ideas:

grvsachdeva commented 5 years ago

Hey @jywarren @SidharthBansal,

There are some projects which can be formed from this issue like Rails upgrade, User Interface, etc. I think we should divide this one into more planning issues.

Regarding installation of dangerbot, codeclimate and dependabot I have opened issue Sidharth. Thanks!

jywarren commented 5 years ago

Yes thanks! but also wanted to have one overview issue to talk about the big picture and if this overall plan sounds doable and reasonable and if we're forgetting anything or if there are other major reorganizing ideas we could consider here too. Thanks!!!

On Fri, Jan 25, 2019, 6:02 PM Gaurav Sachdeva <notifications@github.com wrote:

Hey @jywarren https://github.com/jywarren @SidharthBansal https://github.com/SidharthBansal,

There are some projects formed from this issue like Rails upgrade, User Interface, etc. I think we should divide this one into more planning issues.

Regarding installation of dangerbot, codeclimate and dependabot I have opened issue Sidharth. Thanks!

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/publiclab/mapknitter/issues/300#issuecomment-457726834, or mute the thread https://github.com/notifications/unsubscribe-auth/AABfJyVbvOp4MSSs0hpLGU4v9Fv315R3ks5vG3C-gaJpZM4aN-or .

SidharthBansal commented 5 years ago

I am trying to shift some portion of the crowd from plots2 to mapknitter also so that this repository will become active as plots2, image-sequencer is. I hope @jywarren, @gauravano @ebarry you will like this.

jywarren commented 5 years ago

Great work.

jywarren commented 5 years ago

Made a project to track some of this work!!!

jywarren commented 5 years ago

Opened a more detailed list here for Leaflet.DistortableImage, the UI for map knitting: https://github.com/publiclab/Leaflet.DistortableImage/issues/126

jywarren commented 5 years ago

@kayrufty wrote in with some great UI notes -- just noting to Kay that we have issues open for some, and not others. I'll note connected issues where they exist, and we can break out new ones as we go. THANKS!!!

...actually this one, i'm a bit surprised that it can become unlinked with the images. any clues or screenshots on how this happened, or what led up to it so we can try to reproduce it? Thanks!

IshaGupta18 commented 5 years ago

Yes I think this would be very much needed to make MapKnitter as good as plots2. I am interested in tackling and brainstorming on some of these projects,especially the ones related to MapKnitter UI and I also wanted to chime in some suggestions for UI design for it to be of efficient and smooth use to the public, as I think a lot of brainstorming can be done on making the website easy to use and better organised. I will try to open some planning issues regarding the same for us to discuss there. Does this sound okay @jywarren ?

jywarren commented 5 years ago

Hi @IshaGupta18 -- thanks, that would be great! If you'd like to chime in on the Exporter UI discussion here, that'd be awesome: https://github.com/publiclab/mapknitter/issues/326

I think we could also start one called MapKnitter Editor UI discussion where we can discuss the basic editor layout here: https://mapknitter.org/maps/cranston-test (say, UI for the Uploading, Image listing, Exporting, and the main Leaflet map editing areas). We could copy in some of these issues for discussion there:

* [ ]  image collections/groups rather than "maps"  
  * [ ]  ability to see all images (faded maybe?) for a region and "add to this collection/map" by clicking
* [ ]  view of all images for given region in maps (faded/greyed if not part of this map)
* [ ]  Ability to choose time bounding box (some kind of layer manager maybe needed)
* [ ]  Ability to toggle viewing your images or all images (uploads by other users)
* [ ]  Ability to select multiple images for export " a collection"
jywarren commented 5 years ago

Also note that I've built in a few of these projects with more detail on our Summer of Code program Ideas page: https://publiclab.org/gsoc-ideas, including:

Divy123 commented 5 years ago

@jywarren one thing that I went through the ideas for image-sequencer project. Is that a single idea that is mentioned there under gsoc-ideas or are they multiple?

jywarren commented 5 years ago

Multiple... and as we often get multiple proposals for the same project, we are ok with breaking big ones into pieces. Thanks!

On Thu, Feb 7, 2019, 4:17 PM Slytherin <notifications@github.com wrote:

@jywarren https://github.com/jywarren one thing that I went through the ideas for image-sequencer project. Is that a single idea that is mentioned there under gsoc-ideas or are they multiple?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/publiclab/mapknitter/issues/300#issuecomment-461598773, or mute the thread https://github.com/notifications/unsubscribe-auth/AABfJ9GSsfHOhwGXmNo-uYndHTVLNoS8ks5vLJe2gaJpZM4aN-or .

Divy123 commented 5 years ago

Thanks .

IshaGupta18 commented 5 years ago

@jywarren This would be lovely I think. I will go through all of this is deeper details. Thanks a lot!

SidharthBansal commented 5 years ago

Thanks Isha

On Fri, Feb 8, 2019, 11:59 PM Isha Gupta <notifications@github.com wrote:

@jywarren https://github.com/jywarren This would be lovely I think. I will go through all of this is deeper details. Thanks a lot!

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/publiclab/mapknitter/issues/300#issuecomment-461899569, or mute the thread https://github.com/notifications/unsubscribe-auth/AUACQztT5KuHY701nngZTR4m7PxwjR_Kks5vLcIJgaJpZM4aN-or .

jywarren commented 5 years ago

Added more info on Collections model which would be related many-to-many to Images, instead of Warpables that belong to only one Map.