publiclab / plots2

a collaborative knowledge-exchange platform in Rails; we welcome first-time contributors! :balloon:
https://publiclab.org
GNU General Public License v3.0
961 stars 1.83k forks source link

Create new inline grid for wiki pages, with format [wikis:_tagname_] #1828

Closed jywarren closed 6 years ago

jywarren commented 6 years ago

New feature

Our inline power tags let us make grids for activities, like in https://publiclab.org/wiki/activities

Let's make a new one to display lists of wiki pages! It could have the syntax [wikis:_tagname_] where _tagname_ is something like "balloon-mapping" -- so it would show wiki pages tagged with "balloon-mapping", as currently shown on these pages:

Changes

For how we currently set up a grid using notes, see def notes_grid:

https://github.com/publiclab/plots2/blob/master/app/models/concerns/node_shared.rb#L31-L52

For the template we'll have to copy into _wikis.html.erb, see:

https://github.com/publiclab/plots2/blob/master/app/views/grids/_notes.html.erb

I believe this is it -- but there may be one more step to get this working. Let's start with this and we can ensure it works by adding a test to this file, similarly to how we test notes grids;

https://github.com/publiclab/plots2/blob/master/test/unit/node_shared_test.rb#L4-L12

The end result is that we should be able to put [wikis:test] onto a wiki page, and it should show all wiki pages that have been tagged with the word test.

Make sense? This is a big one, with several moving parts, but it should be easy to write a test for and make progress on. And I'm happy to help! Thanks!

zhirschtritt commented 6 years ago

I'd like to do this one, but does seem quite big! @jywarren If you think this would be okay for me to take on I'll go at it.

jywarren commented 6 years ago

I'd say have a go at it! It has a lot of moving parts but if you're OK with some back-and-forth as we figure it out, I'd love your help. Tnx!

On Fri, Dec 8, 2017 at 2:03 PM, zhirschtirtt notifications@github.com wrote:

I'd like to do this one, but does seem quite big! @jywarren https://github.com/jywarren If you think this would be okay for me to take on I'll go at it.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/publiclab/plots2/issues/1828#issuecomment-350345140, or mute the thread https://github.com/notifications/unsubscribe-auth/AABfJxB-f-lF119I4KS6Q_cboIbHWFXzks5s-YgVgaJpZM4Q4yki .

Diksha2008 commented 6 years ago

@jywarren I would like to work on this if @zhirschtritt hasn't!

jywarren commented 6 years ago

Yes I think so! But also consider this one which is similar and very useful!

https://github.com/publiclab/plots2/issues/1340

On Jan 10, 2018 8:03 AM, "Diksha Manchanda" notifications@github.com wrote:

@jywarren https://github.com/jywarren I would like to work on this if @zhirschtritt https://github.com/zhirschtritt hasn't!

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/publiclab/plots2/issues/1828#issuecomment-356596232, or mute the thread https://github.com/notifications/unsubscribe-auth/AABfJ3ecutQLiialj6fPi6kkAAgg-CHHks5tJLURgaJpZM4Q4yki .

zhirschtritt commented 6 years ago

Sorry I dropped off the map on this!

jywarren commented 6 years ago

no problem! Hope you're well -- and any time you want to work on an issue, ping me!

On Thu, Jan 11, 2018 at 6:21 PM, zhirschtirtt notifications@github.com wrote:

Sorry I dropped off the map on this!

— You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub https://github.com/publiclab/plots2/issues/1828#issuecomment-357094081, or mute the thread https://github.com/notifications/unsubscribe-auth/AABfJ7orEO9Xyv5O4O3HKPfMiNKAPozPks5tJpdygaJpZM4Q4yki .

jywarren commented 6 years ago

also -- i bought a grain mill. rad.

On Fri, Jan 12, 2018 at 3:57 PM, Jeffrey Warren jeff@unterbahn.com wrote:

no problem! Hope you're well -- and any time you want to work on an issue, ping me!

On Thu, Jan 11, 2018 at 6:21 PM, zhirschtirtt notifications@github.com wrote:

Sorry I dropped off the map on this!

— You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub https://github.com/publiclab/plots2/issues/1828#issuecomment-357094081, or mute the thread https://github.com/notifications/unsubscribe-auth/AABfJ7orEO9Xyv5O4O3HKPfMiNKAPozPks5tJpdygaJpZM4Q4yki .