search

pubnub / dart

PubNub Dart SDK
Other
27 stars 15 forks source link

feat/userId #98

Closed mohitpubnub closed 2 years ago

mohitpubnub commented 2 years ago

feat: userId intro

are commented 2 years ago

In general it seems ok, what I don't like is the fact that this makes our internal code less readable with all the keyset.uuid! that we need to make since its no longer final and non-nullable. I think we should either migrate fully to .userId in internal code or figure out a different solution for this

are commented 2 years ago

What do you think about this approach? #99

mohitpubnub commented 2 years ago

What do you think about this approach? #99

Definitely It's more clean. I didn't think about uuid! yet But other refactoring was my upcoming commit to this. 😄

And you have already covered that part.

Yes, #99 is more preferable with less side effect 👍🏻

mohitpubnub commented 2 years ago

not required as other PR includes changes with less code changes.