pulibrary / lux-design-system

Princeton University Library's design system
https://pulibrary.github.io/lux-design-system/
1 stars 1 forks source link

New LuxFooter component Light Theme needs different colors #300

Open sdellis opened 4 months ago

sdellis commented 4 months ago

Current display

The current <lux-footer theme='light' /> variation has a white background. This looks strange on pages that already have a white background because it doesn't differentiate the footer from the rest of the page. There is also text that is invisible to the eye because it's white-on-white.

Screenshot 2024-07-31 at 1 24 15 PM

Desired display

The light theme should have an off-white background var(--color-grayscale-warm-lighter) and the text should be var(--color-rich-black). This is a screen shot of the old color scheme for reference.

Screenshot 2024-07-31 at 1 34 50 PM

Acceptance criteria

Notes

This is currently an Accessibility issue as well since there is no contrast between the background and some text.