Separate "university footer" for broader use - Githubissues

pulibrary / lux-design-system

Princeton University Library's design system

https://pulibrary.github.io/lux-design-system/

1 stars 1 forks source link

Separate "university footer" for broader use #360

Closed hackartisan closed 1 month ago

hackartisan commented 1 month ago

User story

We agreed on the last mockup provided below in comments.

The top part of the new footer includes a lot of elements that are primarily relevant for the library website. We'd like to be able to just include the bottom part, but there a few things it needs to always have:

privacy policy link
accessibility link
copyright statement
copyright infringement link
princeton university logo / link

Acceptance criteria

[ ] there's a lux component LuxUniversityFooter for dark or light mode
[ ] the LuxLibraryFooter includes the new footer and any duplicate links are removed from it.
[ ] If this change touches any of the files referenced in .rubocop_todo.yml create a new ticket to address the rubocop todo.
[ ] I can successfully use this feature with Voice Over in Safari.
[ ] I have checked this feature using one of the following browser extensions and confirmed that it does not add any level A or level AA issues:
- axe dev tools
- Lighthouse
- Wave

Implementation notes, if any

hackartisan commented 1 month ago

Things that are required to be on every page:

The princeton Logo
copyright infringement
accessibility link
copyright statement
privacy notice

all these except accessibility are on princeton.edu (it's higher up on that site)

Maybe re-write this ticket as a "campus footer" and "app footer" distinction.

beth-german commented 1 month ago

Not sure if the balance is quite right

beth-german commented 1 month ago

Nothing in the middle

beth-german commented 1 month ago

Reverse

beth-german commented 1 month ago

hackartisan commented 1 month ago

@beth-german these are great!

christinach commented 1 month ago

Further discussion in slack lux channel

beth-german commented 1 month ago

Matthew suggests using this link for the copyright link in the footer: https://library.princeton.edu/about/policies/copyright-and-permissions-policies

hackartisan commented 1 month ago

@beth-german should we call the link something other than "Copyright Infringement"? Like maybe "Copyright policy"?

beth-german commented 1 month ago

"Library Copyright Policy" or "Copyright Policy"?

hackartisan commented 1 month ago

I think it's clear it's the library policy if you follow the link, probably the shorter version is okay.