Open DavG opened 5 years ago
abinoda
commented
5 years ago @DavG 👋 Thanks for submitting this issue! Question, are you looking for this setting for personal DM reminders or for reminders in channels?
For personal reminders, under "My DM Settings", there's a "More settings" link at the bottom that provides a "Ignore approved" setting. Does this achieve what you are looking for?
abinoda
commented
5 years ago @DavG Also, for team reminders, if you check the "Remind authors after reviews" setting there is a "Needed reviews" option:
DavG
commented
5 years ago Hello @abinoda , I was thinking about the channel reminders.
I just tried the "Remind authors after reviews" feature, but that's not what I want. I just want the "Waiting for review" part to not contains PR with enough approvals. And I don't want a "Waiting for authors" part.
I already tried a lot of settings :(
abinoda
commented
5 years ago @DavG Makes sense.
There's already a backlog issue for this here https://github.com/pullreminders/backlog/issues/115
In the meantime, there is a workaround described in that thread that some of our customers are using, which is the GitHub Action here: https://github.com/pullreminders/label-when-approved-action.
Email us at support@pullreminders.com and we can help your org get access to GitHub Actions in order to set that up.
Hello,
In our workflow, all developers are automatically set as 'reviewers' (thanks to CODEOWNERS file).
But we configured Github Pull Requests with "minimum required approvals: 2" so in the Pull Request index, i don't see PR with approvals >= 2, even if i'm a reviewer on it. Because they are marked as "Approved".
I would expect the same behavior from Pull Reminders. I think Pull Reminders should look at the "Approved" / "Review Required" mark.
As an alternative, maybe a setting like "Ignore Approved" (similar to ignore labels etc.) would do the job.
What do you think ?