search

pulp-platform / snitch_cluster

An energy-efficient RISC-V floating-point compute cluster.
https://pulp-platform.github.io/snitch_cluster/
Apache License 2.0
51 stars 51 forks source link

Replace snitch_icache with cluster_icache dependency #112

Closed micprog closed 7 months ago

micprog commented 8 months ago

In order to keep a single common source for IPs, the snitch_cluster instruction cache was extracted into its own repository. This repository was updated with features from Mempool, allowing reuse of common features, improvements, and bugfixes. This PR updates the icache to point to this new common source through a bender dependency.

colluca commented 8 months ago

Thanks @micprog!

LGTM, only thing I would change concerns the CI fix. Since https://github.com/pulp-platform/common_cells/pull/217 was merged to master already, I would temporarily use that hash in the Bender.yml, so we can then keep the common_cells assertions on with vsim. Later we can bump to v1.33.1. Alternatively, we can wait for the next release altogether (should not be delayed for long anyways).

Let me know what you think, I can implement the remaining changes and merge.

micprog commented 7 months ago

I think waiting shortly for the common_cells release would make sense to keep consistency and maximum testability. Separating the CI fixes from this PR would also be valuable as a separation of concerns.