search

pulsar-edit / pulsar

A Community-led Hyper-Hackable Text Editor
https://pulsar-edit.dev
Other
3.24k stars 137 forks source link

Cirrus: Fix `gem install fpm` on ARM Linux #1008

Closed DeeDeeG closed 4 months ago

DeeDeeG commented 4 months ago

Issue

Arm Linux CI builds are failing on Cirrus. See this failing CI run: https://cirrus-ci.com/task/6219208260845568?logs=prepare#L2634-L2639

Issue Details

From the error message : mkmf.rb can't find header files for ruby at /usr/lib/ruby/include/ruby.h

And from this StackOverflow answer: https://stackoverflow.com/questions/20559255/error-while-installing-json-gem-mkmf-rb-cant-find-header-files-for-ruby

I think we just need to install ruby-dev package in the Debian container.

Solution

Apparently we need ruby-dev (development headers) package to build fpm gem's native extensions now?!

Well, it's an easy fix. Not sure why we didn't need this up until now, but oh, well.

Verification process

Test run in Cirrus: https://cirrus-ci.com/task/5547408132669440

Re-run of the test run in Cirrus: https://cirrus-ci.com/task/4548855918755840

DeeDeeG commented 4 months ago

The Cirrus run for this commit shows "failed" status due to the manually cancelled macOS task, which I cancelled to save credits and since this is an ARM Linux-specific fix that didn't really need a macOS task running, as I've seen a passing macOS Cirrus task from just the last hour or so.

So, feel free to disregard the "failed" Cirrus build and note that the Arm Linux task specifically has gotten further with this fix than the ARM Linux task from just earlier today without the fix. Thanks.

EDIT: A re-run of the ARM Linux task finally passed in Cirrus CI! Woo!

DeeDeeG commented 4 months ago

With passing Cirrus CI and an Approve, I'm merging this! Thanks!