pulumi / pulumi-azure

A Microsoft Azure Pulumi resource package, providing multi-language access to Azure
Apache License 2.0
134 stars 51 forks source link

golangci-lint failure #1691

Closed t0yv0 closed 9 months ago

t0yv0 commented 9 months ago

What happened?

  Running [/home/runner/golangci-lint-1.54.1-linux-amd64/golangci-lint run --out-format=github-actions --path-prefix=provider] in [/home/runner/work/pulumi-azure/pulumi-azure/provider] ...
  level=warning msg="[runner] The linter 'deadcode' is deprecated (since v1.49.0) due to: The owner seems to have abandoned the linter. Replaced by unused."
  level=warning msg="[runner] The linter 'interfacer' is deprecated (since v1.38.0) due to: The repository of the linter has been archived by the owner. "
  level=warning msg="[runner] The linter 'structcheck' is deprecated (since v1.49.0) due to: The owner seems to have abandoned the linter. Replaced by unused."
  level=warning msg="[runner] The linter 'golint' is deprecated (since v1.41.0) due to: The repository of the linter has been archived by the owner. Replaced by revive."
  level=warning msg="[runner] The linter 'varcheck' is deprecated (since v1.49.0) due to: The owner seems to have abandoned the linter. Replaced by unused."
  level=warning msg="[runner] Can't run linter goanalysis_metalinter: buildir: failed to load package digitaltwins: could not load export data: no export data for \"github.com/hashicorp/terraform-provider-azurerm/internal/services/digitaltwins\""
  level=error msg="Running error: 1 error occurred:\n\t* can't run linter goanalysis_metalinter: buildir: failed to load package digitaltwins: could not load export data: no export data for \"github.com/hashicorp/terraform-provider-azurerm/internal/services/digitaltwins\"\n\n"

Error: golangci-lint exit with code 3 Ran golangci-lint in 315811ms

From https://github.com/pulumi/pulumi-azure/actions/runs/7820131749/job/21335742786

golangci-lint-1.54.1-linux-amd64 go 1.21.6

Example

N/A

Output of pulumi about

N/A

Additional context

This is blocking an update.

Contributing

Vote on this issue by adding a 👍 reaction. To contribute a fix for this issue, leave a comment (and link to your pull request, if you've opened one already).

t0yv0 commented 9 months ago

Fixed this by disabling go cache temporarily, the fresh cache didn't have this problem. Looks like the action we use does not appropriately index the cache on the toolchain version.