pulumi / pulumi-eks

A Pulumi component for easily creating and managing an Amazon EKS Cluster
https://www.pulumi.com/registry/packages/eks/
Apache License 2.0
171 stars 82 forks source link

AWS ASG group metrics collection #400

Open disk-edit opened 4 years ago

disk-edit commented 4 years ago

Problem description

Discussion origin: https://pulumi-community.slack.com/archives/CRFURDVQB/p1592844311407700?thread_ts=1592841559.407100&cid=CRFURDVQB

For AWS Autoscaling Groups, the Group metrics are not collected by default. When I check the Monitoring tab on the ASG it has a link "Enable Group Metrics Collection", which I can click to enable it. I want group metrics collected when the group is created.

Affected product version(s)

I am currently running pulumi/eks v0.19.0.

Suggestions for a fix

From the Slack thread above @metral suggested - Seems that exposing the MetricsCollection as an option for the ASG should do the trick. https://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/aws-properties-as-metricscollection.html

disk-edit commented 4 years ago

I just created https://github.com/pulumi/pulumi-aws/issues/1183 because I had forgotten about this ticket. The new ticket expands the request to ask for more ASG properties to be supported.