pulumi / pulumi-terraform-bridge

A library allowing Terraform providers to be bridged into Pulumi.
Apache License 2.0
194 stars 43 forks source link

Validate that resources don't have an input property called "id" #2084

Closed iwahbe closed 1 month ago

iwahbe commented 3 months ago

Hello!

Issue details

Follow up on https://github.com/pulumi/pulumi-meraki/issues/57:

The bridge currently silently swallows input properties called "id". The pulumi model doesn't support input properties called "id", and the bridge should warn (and then error) in this case.

Affected area/feature

This check would properly be added as part of

https://github.com/pulumi/pulumi-terraform-bridge/blob/388299df1025fede7c3a99767e8b255b1d18d630/pf/internal/check/checks.go#L32-L33

I'm not sure if the check is PF specific. If not, we would need a generic (non PF) check accessible to sdkv2 providers.

pulumi-bot commented 3 weeks ago

This issue has been addressed in PR #2279 and shipped in release v3.90.0.