search

pulumi / pulumi-terraform-bridge

A library allowing Terraform providers to be bridged into Pulumi.
Apache License 2.0
194 stars 43 forks source link

Remove the `shim.SchemaMap.{Delete,Set}` method #2098

Closed iwahbe closed 3 months ago

iwahbe commented 3 months ago

It looks like we don't use this anywhere, and I don't expect that there are 3rd party dependencies on shim.SchemaMap.

Follow up on https://github.com/pulumi/pulumi-terraform-bridge/pull/1973#discussion_r1638456558.

codecov[bot] commented 3 months ago

Codecov Report

Attention: Patch coverage is 80.00000% with 12 lines in your changes missing coverage. Please review.

Project coverage is 61.24%. Comparing base (c535463) to head (17cb14d).

Files Patch % Lines
pkg/tf2pulumi/il/schemas.go 78.37% 6 Missing and 2 partials :warning:
pkg/tf2pulumi/convert/tf12.go 77.77% 2 Missing :warning:
pkg/tf2pulumi/il/graph.go 92.30% 1 Missing :warning:
pkg/tfgen/generate.go 0.00% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #2098 +/- ## ========================================== + Coverage 61.18% 61.24% +0.05% ========================================== Files 340 340 Lines 45216 45212 -4 ========================================== + Hits 27664 27688 +24 + Misses 16031 16002 -29 - Partials 1521 1522 +1 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.