Open scottslowe opened 11 months ago
Per @interurban 28 visits over the last 3 months
This doesn't feel like it should be a template, but maybe rather an example. The blog post gets decent placement for "pulumi javascript" so we probably shouldn't remove the blog post, but perhaps we can rework the blog post not to depend on this template so that we can sunset this template entirely.
I'll add a new issue to track the efforts to update the referenced blog post and link to this issue.
Course of action: move to /examples.
This template is referenced elsewhere on the web, though -- it goes back to 2018. Moving it will break all references to it (one of which is a blog post apparently updated as recently a few weeks ago):
https://www.google.com/search?q=%22hello-aws-javascript%22
If we can update the template in place, why wouldn't we just do that? We'd need to do it anyway if it moved to examples, and fundamentally it's no less a template than serverless-aws-typescript
is when you think about it. Both do roughly the same thing: provision a serverless endpoint, output a URL. The only thing that makes this template a little different is its name.
Is there a benefit to having the template not live in this repo? Is that benefit strong enough to cause anyone who runs pulumi new hello-javascript
after reading one of these blog posts (ours or someone else's) to get an obscure error about the template not existing and being stuck? I'm not sure I'd say so.
I'd prefer we kept this template where it is and updated it as needed. There's really no great reason to break this IMO -- and I must admit, it's also kind of neat having it there for Pulumi-historical reasons. 😄
What happened?
The
hello-aws-javascript
template works, but it is using a prerelease (0.40.0) version of AWSX. Unfortunately, simply updatingpackage.json
to^1.0.0
doesn't work. When you make that change,pulumi up
reports:Example
pulumi new hello-aws-javascript
.node_modules
directory andpackage-lock.json
.package.json
to specify^1.0.0
for AWSX.pulumi up
.Output of
pulumi about
Additional context
No response
Contributing
Vote on this issue by adding a 👍 reaction. To contribute a fix for this issue, leave a comment (and link to your pull request, if you've opened one already).