punitda / ComfyRun

Run ComfyUI workflows on powerful cloud GPUs
3 stars 1 forks source link

Error appears when adding a model from Hugging Face #43

Open AmrBoShanab opened 3 days ago

AmrBoShanab commented 3 days ago

Hello Punit,

Thank you for this app. I tried it and it works well.

However, I encounter an error when I click on "Create App" if I have added a model from Hugging Face. If I don't add a model, there is no problem and it builds the application successfully.

The other thing is that although I select some models, I don't find them appearing as options in the contract within ComfyUI. 2024-09-23_160110 2024-09-23_160012

punitda commented 3 days ago

Can you please check and share the logs when you create app using a hugging face model? You can go to https://fly.io/apps/<your_backend_app_name>/monitoring to check the live logs when you hit the create app button.

Can you also share the url you're using for hugging face model so that I can try on my end? Is it https://huggingface.co/glif/loradex-flux-dev/resolve/main/maxxd4240/SketchStrokes/SketchStrokes_000002000.safetensors?download=true?


The other thing is that although I select some models, I don't find them appearing as options in the contract within ComfyUI.

Which models don't appear in your ComfyUI workflows? Is it all or few of them? Please share the list of such models. Thanks!

AmrBoShanab commented 1 day ago

This error appears in monitoring.

2024-09-25_155516

It appears when I have added any model from Hang Face and not on a specific Lora file

punitda commented 1 day ago

Can you share the url you enter in the huggingface model form?

image

If it is a link to hugging face repo, it won't work. It needs to be a direct link to model file's(.safetensors or .pt) download url within that repo. This is because if we just pass the repo url there is no way to know which is the main model file within that repo we need to download

AmrBoShanab commented 16 hours ago

@punitda https://huggingface.co/XLabs-AI/flux-lora-collection/resolve/main/realism_lora_comfy_converted.safetensors

punitda commented 3 hours ago

Thanks for the link! Found out the issue. Fixed in PR #44

Please pull latest changes from main. Let me know if you still face the issue