puniverse / capsule

Dead-Simple Packaging and Deployment for JVM Apps
http://capsule.io
Eclipse Public License 1.0
1.15k stars 100 forks source link

Support proper capsule.jvm.args parsing #106

Closed aalberti closed 8 years ago

aalberti commented 8 years ago

Capsule now parses capsule.jvm.args as command line arguments. It escapes quoted, double quoted parameters, and characters escaped by \

coveralls commented 8 years ago

Coverage Status

Coverage increased (+0.4%) to 60.021% when pulling 2f6aeae92e20d0b0f2e8922cfa5287dc09e5d369 on aalberti:jvm-args-parsing into 2b9a20c347ccc0cb01612e66e7e3fd45e1806751 on puniverse:master.

aalberti commented 8 years ago

OK, I'll do that. In the meantime, I realized I left the company git script that adds a ChangeId to all commit messages (for gerrit). Do you prefer me to add commits with this change id, of rebase the whole chain?

coveralls commented 8 years ago

Coverage Status

Coverage increased (+0.4%) to 60.021% when pulling 6274014103f762a1bef90b0915596ffeff882118 on aalberti:jvm-args-parsing into 2b9a20c347ccc0cb01612e66e7e3fd45e1806751 on puniverse:master.

pron commented 8 years ago

Cool, thanks! Does it work on Windows? Do you have any reason to suspect why it might not?

aalberti commented 8 years ago

You're right, using \ as an escape char is not a good idea on windows... I'm working on it. I might revert this whole addition to ant's cmd line parser, if I don't find a simple clever idea.

coveralls commented 8 years ago

Coverage Status

Coverage increased (+0.4%) to 59.968% when pulling f8e0a93320a134c4466614cffb7e8cd61eeab0d9 on aalberti:jvm-args-parsing into 2b9a20c347ccc0cb01612e66e7e3fd45e1806751 on puniverse:master.

aalberti commented 8 years ago

Unless you have additional comment, I'm considering it done.... and if you agree, I'm gonna need a 1.0.3 release ;)

aalberti commented 8 years ago

Just quickly tested our product with capsule 1.0.3-SNAPSHOT, and it works fine for me. When are you planning a 1.0.3 release?

pron commented 8 years ago

Next week.

aalberti commented 8 years ago

Thanks a lot. Looking forward to it

pron commented 8 years ago

Released.