search

puppetlabs / pupperware

Container fun time lives here.
Other
183 stars 67 forks source link

unknown field "selector" in io.k8s.api.batch.v1beta1.CronJobSpec #191

Closed gameforce closed 4 years ago

gameforce commented 5 years ago

Describe the Bug

running the helm command to install the chart gives an error and fails with the following error:

Error: unable to build kubernetes objects from release manifest: error validating "": error validating data: ValidationError(CronJob.spec): unknown field "selector" in io.k8s.api.batch.v1beta1.CronJobSpec

Expected Behavior

The helm chart is installed without errors

Steps to Reproduce

Steps to reproduce the behavior:

  1. Go to 'k8s/'
  2. Run 'helm install --namespace puppetserver puppetserver ./ --set puppetserver.puppeturl='git_url_here'

Environment

n/a

Additional Context

I suspect its something wrong/missing in templates/r10k-cronjob.yaml

gameforce commented 5 years ago

closed by accident sorry

underscorgan commented 4 years ago

@Xtigyro can you take a look?

Xtigyro commented 4 years ago

@underscorgan Yes - will do.

@gameforce Could you please test with the code here: https://github.com/Xtigyro/puppetserver-helm-chart/tree/v151

Xtigyro commented 4 years ago

@gameforce I was unable to reproduce your issue with the current chart v1.2.2.

That's the command used:
helm install --namespace puppetserver --name puppetserver ./ --set puppetserver.puppeturl='https://github.com/Xtigyro/puppet-control-repo.git'

The resources that were created:

/repos/xtigyro/pupperware/k8s # kubectl get --namespace puppetserver all -l app=puppetserver
NAME                                READY   STATUS      RESTARTS   AGE
pod/postgres-77c8c9d64f-xsc6z       1/1     Running     0          5m56s
pod/puppetdb-f97486c46-n7sbq        1/1     Running     0          5m56s
pod/puppetserver-5f65d65b88-2ztf8   1/1     Running     0          5m56s
pod/r10k-deploy-1575325200-p8zhz    0/1     Completed   0          4m23s
pod/r10k-deploy-1575325320-jljbw    0/1     Completed   0          2m23s
pod/r10k-deploy-1575325440-cd5lz    0/1     Completed   0          23s

NAME               TYPE        CLUSTER-IP     EXTERNAL-IP   PORT(S)             AGE
service/postgres   ClusterIP   10.0.32.149    <none>        5432/TCP            5m56s
service/puppet     ClusterIP   10.0.246.181   <none>        8140/TCP            5m56s
service/puppetdb   ClusterIP   10.0.87.238    <none>        8080/TCP,8081/TCP   5m56s

NAME                           READY   UP-TO-DATE   AVAILABLE   AGE
deployment.apps/postgres       1/1     1            1           5m56s
deployment.apps/puppetdb       1/1     1            1           5m56s
deployment.apps/puppetserver   1/1     1            1           5m56s

NAME                                      DESIRED   CURRENT   READY   AGE
replicaset.apps/postgres-77c8c9d64f       1         1         1       5m56s
replicaset.apps/puppetdb-f97486c46        1         1         1       5m56s
replicaset.apps/puppetserver-5f65d65b88   1         1         1       5m56s

NAME                               COMPLETIONS   DURATION   AGE
job.batch/r10k-deploy-1575325200   1/1           59s        4m23s
job.batch/r10k-deploy-1575325320   1/1           2s         2m23s
job.batch/r10k-deploy-1575325440   1/1           3s         23s

NAME                        SCHEDULE      SUSPEND   ACTIVE   LAST SCHEDULE   AGE
cronjob.batch/r10k-deploy   */2 * * * *   False     0        28s             5m56s
Xtigyro commented 4 years ago

@gameforce And could you please paste your values.yaml? Of course, please mask any sensitive information in it.

gameforce commented 4 years ago

I think I found the problem, using the wrong helm version:

$ helm version
version.BuildInfo{Version:"v3.0.0", GitCommit:"e29ce2a54e96cd02ccfce88bee4f58bb6e2a28b6", GitTreeState:"clean", GoVersion:"go1.13.4"}

Downgrading that worked. Sorry for the hassle

Xtigyro commented 4 years ago

@gameforce Ah - yes. We're gonna support Helm v3 which was released a few weeks ago. It needs to mature more. I think in 3-6 months might be a good time to migrate the code.

Thank you for filing the issue! It was still useful to know that some people have started playing around with Helm v3.

@underscorgan Closing the issue.