puppetlabs / puppet_operational_dashboards

Apache License 2.0
5 stars 22 forks source link

Add yaml templates - remove dependency on toml gem #219

Closed zoojar closed 4 days ago

bastelfreak commented 2 months ago

hi @zoojar , thanks for the PR! Do you have some links to the telegraf docs that mention the yaml format? I didn't know that's supported and I didn't find it in the docs.

zoojar commented 2 months ago

hi @zoojar , thanks for the PR! Do you have some links to the telegraf docs that mention the yaml format? I didn't know that's supported and I didn't find it in the docs.

@bastelfreak, no worries! I can't see anywhere where telegraf supports yaml. BUT, this is to remove the dependency on the toml gem - the templates are only used as hashes to pass to the telegraf input defined type!

By offering an option of toml or yaml, allows users to still copy and paste in toml for their templates if they want to. But if you want to avoid having to install the toml-rb gem then you can just use yaml for the input data.

MartyEwings commented 1 week ago

Iv resolved some issues with the CI if anyone would like to try this one again

zoojar commented 6 days ago

Iv resolved some issues with the CI if anyone would like to try this one again

thank you. I'm not sure it's working - failing on setup

MartyEwings commented 6 days ago

@zoojar i had to pin a gem, you probably need to rebase to suck it in

zoojar commented 5 days ago

@zoojar i had to pin a gem, you probably need to rebase to suck it in

cheers, now done, but failing on one os: https://github.com/puppetlabs/puppet_operational_dashboards/actions/runs/12029742951/job/33535840586?pr=219

MartyEwings commented 5 days ago

@zoojar i think thats a grafana/sles incompatibility rather than an issue

zoojar commented 5 days ago

@zoojar i had to pin a gem, you probably need to rebase to suck it in

after the rebase. failing on the same checks that ran with #222

MartyEwings commented 4 days ago

@zoojar Sles i think has an a compatibility issue for a while dont sweat it, iv got some due diligence to do then ill merge