puppetlabs / ruby-hocon

A Ruby port of the Typesafe Config library.
Apache License 2.0
34 stars 30 forks source link

(TK-160) fix remaining "valid conf" parser tests #45

Closed cprice404 closed 9 years ago

MSLilah commented 9 years ago

I just had a couple of minor comments. I'm :+1: otherwise. Also, looks like this needs a rebase.

cprice404 commented 9 years ago

rebased and added a commit that fixes the things @fpringvaldsen pointed out.

MSLilah commented 9 years ago

:+1:

KevinCorcoran commented 9 years ago

It looks like Parseable is missing parseConfigDocument ... not sure if this intended to be a total port of that class or not.

cprice404 commented 9 years ago

that configDocument stuff will get dealt with when we port @fpringvaldsen 's stuff down so i'm not too worried about it.