(HC-81) Fix undefined method `value_type_name' error

puppetlabs / ruby-hocon

A Ruby port of the Typesafe Config library.

Apache License 2.0

34 stars 30 forks source link

(HC-81) Fix undefined method `value_type_name' error #80

Closed janelu2 closed 8 years ago

janelu2 commented 8 years ago

This repo currently does not consistently and correctly use calls to value_type_name, causing undefined method errors. This PR fixes all calls to correctly call the module/class method rather than an instance method which does not exist. This PR also adds two spec tests to make sure that it is correctly attempting to parse arrays and throwing a ConfigWrongTypeError.

janelu2 commented 8 years ago

@cprice404 :smile:

jpinsonault commented 8 years ago

This looks good to me, once the comments chris made are addressed

cprice404 commented 8 years ago

+1 other than minor comments above.

janelu2 commented 8 years ago

@cprice404 updated, give it a final check?

cprice404 commented 8 years ago

nice job