search

pupunzi / jquery.mb.vimeo_player

A jQuery plug-in to play any Vimeo video as background of your page
https://pupunzi.com/mb.components/mb.vimeo_player/demo/index.html
59 stars 30 forks source link

would this add to bower? #1

Closed weilinzung closed 7 years ago

weilinzung commented 7 years ago

would this add to bower? thanks!

pupunzi commented 7 years ago

You should find it on bower now.

weilinzung commented 7 years ago

I try to search on bower.io, but nothing over there. or run bower install jQuery.mb.vimeo_player --save not fund.

pupunzi commented 7 years ago

Just tested successfully: bower install jquery.mb.vimeo_player

Don't know why it's not listed on bower.io

weilinzung commented 7 years ago

ok. now it is working, but the repo has no dist folder and bower.json. Would this cause any issues?

when I run gulp watch or gulp production it seems not combine this Vimeo scrips to my main JS. Uncaught TypeError: $(...).vimeoPlayer is not a function at HTMLDocument.<anonymous> (main.js:90) at f (jquery.js:3583) at p (jquery.js:3651)

I did the same way to install this Vimeo script like Youtube one, but the youtube one is running fine.

thanks!

weilinzung commented 7 years ago

I figure out why always said Uncaught TypeError.

The Repo one and the Demo one has different config name which are jQuery.vimeoPlayer(demo & doc ) and jQuery.vimeo_player(repo).

Please fix.