search

purescript-concur / purescript-concur-react

Concur UI Framework for Purescript
https://purescript-concur.github.io/purescript-concur-react
MIT License
271 stars 17 forks source link

Guarantee async effects #7

Closed anttih closed 6 years ago

anttih commented 6 years ago

Guarantee that all async effects are in fact async by forcing this at the driver level. The current affAction is problematic because it doesn't properly clean up the losing side of <|>.

This fixes the issue by guaranteeing that the IO is always run after the view has been rendered.

ajnsit commented 6 years ago

I'm not sure what problem this is solving. Do you have an example where the current implementation doesn't work correctly?

Also, with these changes, the async examples become buggy. To see this run - npm run-script build-example and open html/index.html in a browser, and try running multiple timers, or making multiple ajax calls in parallel.

anttih commented 6 years ago

Yeah, sadly this doesn't work. I'll think about this some more and create the issue first. I'll close this one for now.