purescript-contrib / pulp

A build tool for PureScript projects
GNU Lesser General Public License v3.0
445 stars 86 forks source link

Put executable names into a central list of constants #344

Closed Profpatsch closed 6 years ago

Profpatsch commented 6 years ago

This way there is one place where the paths of required external tools can be changed at compile time (e.g. to patch in absolute paths for nix).

This is a rather large patch because pulp calls to external tools in a lot of places. Some interesting changes are in Test.purs and Version.purs.

This is part of an ongoing effort to package all Purescript tooling for nixpkgs in a nice way.

hdgarrood commented 6 years ago

I'm not hugely keen on this approach, because I worry I'm unlikely to remember to keep it set up this way in the future. Have you considered any other approaches? Would it work to have a wrapper script to set up the PATH prior to running pulp instead, for instance?

Profpatsch commented 6 years ago

Would it work to have a wrapper script to set up the PATH prior to running pulp instead, for instance?

Hm, we can create a wrapper script. It’s not as clean on downstream, though.