purescript-contrib / purescript-formatters

Formatting and printing for numeric and date/time/interval values
Apache License 2.0
41 stars 30 forks source link

Update for compiler 0.12 #48

Closed thomashoneyman closed 6 years ago

thomashoneyman commented 6 years ago

Hey folks -- this PR is an extension of the version bump that @justinwoo has already provided. If it isn't adding enough on top I'm perfectly fine closing this in favor of his PR.

This PR passes the test suite.

Specifically this PR introduces:

However, this is not yet ready to merge: it's waiting on purescript-parsing but is proven to work using the open PR in that repository from @joncfoo. Once that is merged or similar action is taken this can be merged in as well.

CLAassistant commented 6 years ago

CLA assistant check
All committers have signed the CLA.

davezuch commented 6 years ago

This PR should now be ready to merge as the dependent PR for purescript-parsing has been merged and I've just fixed the bower config to point to it.

natefaubion commented 6 years ago

@garyb @cryogenian Can we merge this?

thomashoneyman commented 6 years ago

I believe Gary wanted to fix this before releasing: https://github.com/slamdata/purescript-formatters/issues/45

cryogenian commented 6 years ago

Going to merge this #45 could go into minor/patch release