Closed thomashoneyman closed 6 years ago
This PR should now be ready to merge as the dependent PR for purescript-parsing
has been merged and I've just fixed the bower config to point to it.
@garyb @cryogenian Can we merge this?
I believe Gary wanted to fix this before releasing: https://github.com/slamdata/purescript-formatters/issues/45
Going to merge this #45 could go into minor/patch release
Hey folks -- this PR is an extension of the version bump that @justinwoo has already provided. If it isn't adding enough on top I'm perfectly fine closing this in favor of his PR.
This PR passes the test suite.
Specifically this PR introduces:
toCharArray
andfromCharArray
are now fromData.String.CodeUnits
instead ofData.String
. There has been discussion about when to use code units vs. code points and that may be worth considering before merging.id
toidentity
and removing effect rowstransformers
However, this is not yet ready to merge: it's waiting on
purescript-parsing
but is proven to work using the open PR in that repository from @joncfoo. Once that is merged or similar action is taken this can be merged in as well.