Improve view adapters loading on `open` directive

puse / machina

Proof-of-concept browser automation toolkit :construction:

Mozilla Public License 2.0

1 stars 0 forks source link

Improve view adapters loading on `open` directive #19

Closed antaranyan closed 1 year ago

antaranyan commented 1 year ago

In view adapters with Playwright, loading issues are fixed by adding more loading time. Could be improved for adding stability and dropping unnecessary overhead.

Originally posted by @antaranyan in https://github.com/despan/machina/issues/18#issuecomment-1264875341 May be related to #10

antaranyan commented 1 year ago

Open Twitter profile

Success

When page.waitForSelector('[data-testid="UserName"]') resolves

Failure

When page.goto(url) rejected
When page.waitForSelector('[data-testid="emptyState"]') resolves
When page.waitForSelector('[data-testid="UserName"]') rejected with timeout

antaranyan commented 1 year ago

Open Twitter profile

Success

When page.waitForSelector('[data-testid="tweet"]') resolves

Failure

When page.goto(url) rejected
When page.waitForSelector('[data-testid="emptyState"]') resolves
When page.waitForSelector('[data-testid="Tweet"]') rejected with timeout

antaranyan commented 1 year ago

Reopening as issues with tests. For some reason CI was skipped.