The current bootstrap date picker gives the ability to show week numbers in the calendar. This is quite a useful feature for countries that are used to using week numbers with regards to dates. This PR adds a the ability for the date picker to show week numbers.
Motivation and Context
As mentioned above, many countries especially in Scandinavia address weeks and or dates by week numbers and this is often a very handy UI component to have when selecting dates from a date picker. Adding this as an optional functionality further enriches the react date picker library to be able to suit these needs and address the problem of not having the calendar weeks.
How Has This Been Tested?
I have run this through the appropriate tests and seem to get a single fail point on an assertion that as far as I can tell has nothing to do with the week number edits. However if someone else sees that my changes have indeed created this error I will fix it. I have also tested manually the week numbers to make sure that edge cases such as leap years, and years (such as 2010) have proper week numbers addressed to the weeks. I used the Wikipedia week number ISO standard table as a reference.
Screenshots (if appropriate):
Types of changes
[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)
Checklist:
[x] My code follows the code style of this project.
[x] My change requires a change to the documentation.
[x] I have updated the documentation accordingly.
[ ] I have added tests to cover my changes.
[ ] All new and existing tests passed.
I have updated the example page but not the documentation. This can be done if necessary. I left the added and current tests empty as I get the same single error when I run my tests before any of my changes. So although there is one error present it is present before my changes.
Let me know if there are any changes and Ill be happy to address them! We planning on using this in production for a soon to be release and I will be prompt with my responses!
Cheers
Description
The current bootstrap date picker gives the ability to show week numbers in the calendar. This is quite a useful feature for countries that are used to using week numbers with regards to dates. This PR adds a the ability for the date picker to show week numbers.
Motivation and Context
As mentioned above, many countries especially in Scandinavia address weeks and or dates by week numbers and this is often a very handy UI component to have when selecting dates from a date picker. Adding this as an optional functionality further enriches the react date picker library to be able to suit these needs and address the problem of not having the calendar weeks.
How Has This Been Tested?
I have run this through the appropriate tests and seem to get a single fail point on an assertion that as far as I can tell has nothing to do with the week number edits. However if someone else sees that my changes have indeed created this error I will fix it. I have also tested manually the week numbers to make sure that edge cases such as leap years, and years (such as 2010) have proper week numbers addressed to the weeks. I used the Wikipedia week number ISO standard table as a reference.
Screenshots (if appropriate):
Types of changes
Checklist:
I have updated the example page but not the documentation. This can be done if necessary. I left the added and current tests empty as I get the same single error when I run my tests before any of my changes. So although there is one error present it is present before my changes.
Let me know if there are any changes and Ill be happy to address them! We planning on using this in production for a soon to be release and I will be prompt with my responses! Cheers