search

pvande / Milk

Milk is Mustache in CoffeeScript -- great with your browser or NodeJS!
http://pvande.github.com/Milk
188 stars 19 forks source link

milk.js's use of "char" keyword kills YUI Compressor #2

Closed agibralter closed 13 years ago

agibralter commented 13 years ago

On line 43 of milk.js char is a JS keyword and should be in quotes...

https://github.com/pvande/Milk/blob/87dc308b638afc58801cd190bc180fc6e834feb7/milk.js#L43

But char is also used here and causes trouble:

https://github.com/pvande/Milk/blob/87dc308b638afc58801cd190bc180fc6e834feb7/milk.js#L280

Could I suggest just changing the variable names to character?

agibralter commented 13 years ago

http://www.quackit.com/javascript/javascript_reserved_words.cfm