search

pvarki / rasenmaeher-ui

0 stars 1 forks source link

[Bugfix 1.0] Quickfix getOperatingSystem, used to determine instructions in CreateMtlsView #13

Closed benjamsf closed 10 months ago

benjamsf commented 10 months ago

What

Rather temporarily fix a problem that appears to occur with various Android devices, with how /assets/helpers/getOperatingSystem is made to work. The implementation thinks some android flavour devices are "linux."

Also a little typo in QuickstartGuide wintak.

Why

As CreateMtlsView uses this helper to determine which instructions to show the user, this is rather irritating bug.

Changes

Remove the option of determining "a Linux" altogether and make the determination to fallback to Android if that is the case.

What next

Should make this logic not this fragile in the future & probably include CreateMtlsView a feature for the user to change the instruction type themselves.

benjamsf commented 10 months ago

The thing is kind of dumb rn. As of many androids state Linux Android as their user agent, so I need to figure out some other way to determine "Linux" if that is actually feasible anyway. However, due we don't really need linux flavor users right now (as wintak is the only desktop payload software), this would suffice.