search

pvvx / ZigbeeTLc

Custom firmware for Zigbee 3.0 IoT devices on the TLSR825x chip
Other
321 stars 15 forks source link

Fixed typos in LYWSD03MMC converter 2.0 #90

Closed maaad closed 2 months ago

maaad commented 2 months ago

Sry, previous pr was broken

pvvx commented 2 months ago

It works? I don't use Z2M. ZHA does not require any converters...

maaad commented 2 months ago

Yes, it works with LYWSD03MMC-z.

pvvx commented 2 months ago

"index.json" is required in Z2M ?

maaad commented 2 months ago

Yes, it works if you define it in zigbee_ota_override_index_location. BTW, it should be merged it in global Zigbee-OTA index

robvanoostenrijk commented 2 months ago

@maaad, I can see you changed the min and max value definitions away from the values provided in the ZigbeeTLc documentation:

https://github.com/pvvx/ZigbeeTLc/

Supported values are -372.67..327.67, but its changed to -50..50.

@pvvx, I guess the question here is to support what is technically exposed or rather what makes sense to the user?

pvvx commented 2 months ago

I don't know if the graphics scale is scalable in Z2M or not. So I limited the script to values that make sense.

maaad commented 2 months ago

@maaad, I can see you changed the min and max value definitions away from the values provided in the ZigbeeTLc documentation:

https://github.com/pvvx/ZigbeeTLc/

Supported values are -372.67..327.67, but its changed to -50..50.

I didn't change it (https://github.com/pvvx/ZigbeeTLc/commit/576ee036c757865389ff2ac068dca61254dbf9be) BTW, https://github.com/devbis/z03mmc/blob/master/converters/lywsd03mmc.js uses -100..100