search

pwittchen / spotify-cli-linux

🎶 A command line interface to Spotify on Linux
https://pwittchen.github.io/spotify-cli-linux
GNU General Public License v3.0
643 stars 55 forks source link

Changed version check to all Python 3 versions, not just 3.7+ #46

Closed hnefatl closed 5 years ago

hnefatl commented 5 years ago

The version-guarded code chunks in spotifycli.py fail to run on any Python version >2, not just >3.6 (source).

This PR updates the check to prevent errors when installing the package with eg. Python 3.5 instead of Python 3.7.

pwittchen commented 5 years ago

Thanks, I'll review it soon.

-- Piotr Wittchen, http://wittchen.io

pt., 10 maj 2019, 18:38 użytkownik Keith Collister notifications@github.com napisał:

The version-guarded code chunks in spotifycli.py fail to run on any Python version >2, not just >3.6 (source https://docs.python.org/3.5/whatsnew/3.0.html).

This PR updates the check to prevent errors when installing the package with eg. Python 3.5 instead of Python 3.7.

You can view, comment on, or merge this pull request online at:

https://github.com/pwittchen/spotify-cli-linux/pull/46 Commit Summary

  • Allowed all versions of python 3

File Changes

Patch Links:

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/pwittchen/spotify-cli-linux/pull/46, or mute the thread https://github.com/notifications/unsubscribe-auth/AAFJYF63PEQDFC5OBOOE2L3PUWQITANCNFSM4HMETCTQ .