search

pwntester / octo.nvim

Edit and review GitHub issues and pull requests from the comfort of your favorite editor
MIT License
2.42k stars 136 forks source link

Default pr list to open prs #134

Closed jpribyl closed 3 years ago

jpribyl commented 3 years ago

Describe what this PR does / why we need it

Problem: In a production environment, it's common to have 1000s of PRs and unless I use a browser, I'm not going to know what is currently open and what is not. It's tedious to always type Octo pr list states=OPEN

Solution: default the state argument to "OPEN" - this matches the behavior of the gh-cli's gh pr list https://cli.github.com/manual/gh_pr_list

Does this pull request fix one issue?

NONE

Describe how you did it

Added a default for opts.states in menu.pull_requests

Describe how to verify it

  1. Open vim
  2. Run Octo pr list to verify that open works
  3. Run Octo pr list states=CLOSED to verify that closed works
  4. Run Octo pr list states=MERGED to verify that merged works

Special notes for reviews

pwntester commented 3 years ago

Thanks!

jpribyl commented 3 years ago

@pwntester oops, I didn't quite get around to adding a similar default for issues! I will open another PR

jpribyl commented 3 years ago

nvm, looks like you did it :+1: thanks for taking care of that!

pwntester commented 3 years ago

No problem, thanks for the PR!